From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qA6GtgUR076334 for ; Tue, 6 Nov 2012 10:55:42 -0600 Message-ID: <5099417E.3080509@sgi.com> Date: Tue, 06 Nov 2012 10:57:34 -0600 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH v6 09/10] xfs: add minimum file size filtering to eofblocks scan References: <1352213447-59791-1-git-send-email-bfoster@redhat.com> <1352213447-59791-10-git-send-email-bfoster@redhat.com> In-Reply-To: <1352213447-59791-10-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com On 11/06/12 08:50, Brian Foster wrote: > Support minimum file size filtering in the eofblocks scan. The > caller must set the XFS_EOF_FLAGS_MINFILESIZE flags bit and minimum > file size value in bytes. > > Signed-off-by: Brian Foster > --- > fs/xfs/xfs_fs.h | 6 ++++-- > fs/xfs/xfs_icache.c | 11 +++++++++-- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h > index 88eb1bc..082b743 100644 > --- a/fs/xfs/xfs_fs.h > +++ b/fs/xfs/xfs_fs.h > @@ -348,7 +348,8 @@ struct xfs_eofblocks { > uid_t eof_uid; > gid_t eof_gid; > prid_t eof_prid; > - __u32 pad[27]; > + __u64 eof_min_file_size; > + __u32 pad[25] ^^ Glad you bumped it to a unsigned 64 bit value. Are __u64 items 64 bits? if so, the pad would be 24 > }; > Looks good. Reviewed-by: Mark Tinguely