Re: [PATCH v7 09/10] xfs: add minimum file size filtering to eofblocks scan

Dave Chinner
2012-11-07T20:32:29Z

On Wed, Nov 07, 2012 at 12:21:14PM -0500, Brian Foster wrote:
> Support minimum file size filtering in the eofblocks scan. The
> caller must set the XFS_EOF_FLAGS_MINFILESIZE flags bit and minimum
> file size value in bytes.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
> ---
>
> v7:
> - Add eof_min_file_size such that it is aligned.
> - Updated flags style.
>
> fs/xfs/xfs_fs.h | 7 +++++--
> fs/xfs/xfs_icache.c | 11 +++++++++--
> 2 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h
> index 7113564..8455c9c 100644
> --- a/fs/xfs/xfs_fs.h
> +++ b/fs/xfs/xfs_fs.h
> @@ -349,7 +349,8 @@ struct xfs_eofblocks {
> gid_t eof_gid;
> prid_t eof_prid;
> __u32 pad32;
> - __u64 pad64[13];
> + __u64 eof_min_file_size;
> + __u64 pad64[12];
> };

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com