From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH RFC] xfs_spaceman: updated preallocation support (eofblocks v6)
Date: Tue, 06 Nov 2012 17:58:52 -0500 [thread overview]
Message-ID: <5099962C.9030404@redhat.com> (raw)
In-Reply-To: <20121106224337.GL24575@dastard>
On 11/06/2012 05:43 PM, Dave Chinner wrote:
> On Tue, Nov 06, 2012 at 09:55:04AM -0500, Brian Foster wrote:
>...
>> I can also squash this into the original and post a new version if that is
>> preferred.
>
> I'll probably do that myself - the current code I have is a little
> different so the patch probably won't apply, anyway. I'll need to
> munge it to suit the eventual struct xfs_eofblocks format, anyway.
>
Ok, I'll have a v2 replacement of this once the alignment thing is fixed
up...
>
>> @@ -136,7 +142,7 @@ prealloc_help(void)
>> "\n"
...
>> - prealloc_cmd.argmin = 1;
>> + prealloc_cmd.argmin = 0;
>
> While technically correct, it's not the desired behaviour. I wanted
> it to issue the usage if you just type the comment. I think I need
> to add a "-a" flag for "flush all" here.
>
Ok.
>> - prealloc_cmd.oneline = _("Control specualtive preallocation");
>> + prealloc_cmd.oneline = _("Control speculative preallocation");
>
> Good catch, Brain! :)
>
Today a typo, tomorrow the world! ;)
Brain
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-11-06 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 14:55 [PATCH RFC] xfs_spaceman: updated preallocation support (eofblocks v6) Brian Foster
2012-11-06 22:43 ` Dave Chinner
2012-11-06 22:58 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5099962C.9030404@redhat.com \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox