* [PATCH v2] xfstests: get return value in seek_sanity_test
@ 2012-10-21 13:15 wenqing.lz
2012-10-21 13:13 ` Jie Liu
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: wenqing.lz @ 2012-10-21 13:15 UTC (permalink / raw)
To: xfs; +Cc: Jeff Liu, Zheng Liu
From: Zheng Liu <wenqing.lz@taobao.com>
In seek_sanity_test getting return value is missing. Thus we couldn't get the
result unless someone read the log file (e.g. # 285).
CC: Jeff Liu <jeff.liu@oracle.com>
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
v2 <- v1:
* put return value check below the run_test()
Hi Jeff,
Could you please review this patch again? Thanks.
Regards,
Zheng
src/seek_sanity_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index 34f5508..3897f02 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -674,9 +674,9 @@ int main(int argc, char **argv)
goto out;
for (i = 0; i < numtests; ++i) {
+ ret = run_test(&seek_tests[i]);
if (ret)
- goto out;
- run_test(&seek_tests[i]);
+ break;
}
out:
--
1.7.12.rc2.18.g61b472e
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-10-21 13:15 [PATCH v2] xfstests: get return value in seek_sanity_test wenqing.lz
@ 2012-10-21 13:13 ` Jie Liu
2012-11-09 3:25 ` Zheng Liu
2012-11-20 15:26 ` Mark Tinguely
2 siblings, 0 replies; 7+ messages in thread
From: Jie Liu @ 2012-10-21 13:13 UTC (permalink / raw)
To: wenqing.lz; +Cc: Zheng Liu, xfs
On 10/21/12 21:15, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing. Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> CC: Jeff Liu <jeff.liu@oracle.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
> v2 <- v1:
> * put return value check below the run_test()
>
> Hi Jeff,
>
> Could you please review this patch again? Thanks.
>
> Regards,
> Zheng
>
> src/seek_sanity_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..3897f02 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
> goto out;
>
> for (i = 0; i < numtests; ++i) {
> + ret = run_test(&seek_tests[i]);
> if (ret)
> - goto out;
> - run_test(&seek_tests[i]);
> + break;
> }
>
> out:
Looks good to me, thank you!
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-10-21 13:15 [PATCH v2] xfstests: get return value in seek_sanity_test wenqing.lz
2012-10-21 13:13 ` Jie Liu
@ 2012-11-09 3:25 ` Zheng Liu
2012-11-09 5:38 ` Jeff Liu
2012-11-09 14:30 ` Mark Tinguely
2012-11-20 15:26 ` Mark Tinguely
2 siblings, 2 replies; 7+ messages in thread
From: Zheng Liu @ 2012-11-09 3:25 UTC (permalink / raw)
To: xfs; +Cc: Jeff Liu, Zheng Liu
On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:
ping?
Regards,
Zheng
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing. Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> CC: Jeff Liu <jeff.liu@oracle.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
> v2 <- v1:
> * put return value check below the run_test()
>
> Hi Jeff,
>
> Could you please review this patch again? Thanks.
>
> Regards,
> Zheng
>
> src/seek_sanity_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..3897f02 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
> goto out;
>
> for (i = 0; i < numtests; ++i) {
> + ret = run_test(&seek_tests[i]);
> if (ret)
> - goto out;
> - run_test(&seek_tests[i]);
> + break;
> }
>
> out:
> --
> 1.7.12.rc2.18.g61b472e
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-11-09 3:25 ` Zheng Liu
@ 2012-11-09 5:38 ` Jeff Liu
2012-11-09 14:30 ` Mark Tinguely
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Liu @ 2012-11-09 5:38 UTC (permalink / raw)
To: Zheng Liu; +Cc: hch, Zheng Liu, tinguely, xfs
CC to Christoph and Mark.
Thanks,
-Jeff
On 11/09/2012 11:25 AM, Zheng Liu wrote:
> On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:
>
> ping?
>
> Regards,
> Zheng
>
>> From: Zheng Liu <wenqing.lz@taobao.com>
>>
>> In seek_sanity_test getting return value is missing. Thus we couldn't get the
>> result unless someone read the log file (e.g. # 285).
>>
>> CC: Jeff Liu <jeff.liu@oracle.com>
>> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
>> ---
>> v2 <- v1:
>> * put return value check below the run_test()
>>
>> Hi Jeff,
>>
>> Could you please review this patch again? Thanks.
>>
>> Regards,
>> Zheng
>>
>> src/seek_sanity_test.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
>> index 34f5508..3897f02 100644
>> --- a/src/seek_sanity_test.c
>> +++ b/src/seek_sanity_test.c
>> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>> goto out;
>>
>> for (i = 0; i < numtests; ++i) {
>> + ret = run_test(&seek_tests[i]);
>> if (ret)
>> - goto out;
>> - run_test(&seek_tests[i]);
>> + break;
>> }
>>
>> out:
>> --
>> 1.7.12.rc2.18.g61b472e
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-11-09 3:25 ` Zheng Liu
2012-11-09 5:38 ` Jeff Liu
@ 2012-11-09 14:30 ` Mark Tinguely
2012-11-17 6:06 ` Jeff Liu
1 sibling, 1 reply; 7+ messages in thread
From: Mark Tinguely @ 2012-11-09 14:30 UTC (permalink / raw)
To: Zheng Liu; +Cc: Jeff Liu, Zheng Liu, xfs
On 11/08/12 21:25, Zheng Liu wrote:
> On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:
>
> ping?
>
> Regards,
> Zheng
>
>> From: Zheng Liu<wenqing.lz@taobao.com>
>>
>> In seek_sanity_test getting return value is missing. Thus we couldn't get the
>> result unless someone read the log file (e.g. # 285).
>>
>> CC: Jeff Liu<jeff.liu@oracle.com>
>> Signed-off-by: Zheng Liu<wenqing.lz@taobao.com>
>> ---
>> v2<- v1:
>> * put return value check below the run_test()
>>
>> Hi Jeff,
>>
>> Could you please review this patch again? Thanks.
>>
>> Regards,
>> Zheng
>>
>> src/seek_sanity_test.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
>> index 34f5508..3897f02 100644
>> --- a/src/seek_sanity_test.c
>> +++ b/src/seek_sanity_test.c
>> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>> goto out;
>>
>> for (i = 0; i< numtests; ++i) {
>> + ret = run_test(&seek_tests[i]);
>> if (ret)
>> - goto out;
>> - run_test(&seek_tests[i]);
>> + break;
>> }
>>
>> out:
>> --
>> 1.7.12.rc2.18.g61b472e
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
Hi Jeff and Zheng,
Jeff, can I assume by your email:
http://oss.sgi.com/archives/xfs/2012-10/msg00412.html
that you are giving your Reviewed-by:?
It also looks good to me too:
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
I will make sure it gets committed.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-11-09 14:30 ` Mark Tinguely
@ 2012-11-17 6:06 ` Jeff Liu
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Liu @ 2012-11-17 6:06 UTC (permalink / raw)
To: Mark Tinguely; +Cc: xfs, Zheng Liu, Zheng Liu
On 11/09/2012 10:30 PM, Mark Tinguely wrote:
> On 11/08/12 21:25, Zheng Liu wrote:
>> On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:
>>
>> ping?
>>
>> Regards,
>> Zheng
>>
>>> From: Zheng Liu<wenqing.lz@taobao.com>
>>>
>>> In seek_sanity_test getting return value is missing. Thus we couldn't get the
>>> result unless someone read the log file (e.g. # 285).
>>>
>>> CC: Jeff Liu<jeff.liu@oracle.com>
>>> Signed-off-by: Zheng Liu<wenqing.lz@taobao.com>
>>> ---
>>> v2<- v1:
>>> * put return value check below the run_test()
>>>
>>> Hi Jeff,
>>>
>>> Could you please review this patch again? Thanks.
>>>
>>> Regards,
>>> Zheng
>>>
>>> src/seek_sanity_test.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
>>> index 34f5508..3897f02 100644
>>> --- a/src/seek_sanity_test.c
>>> +++ b/src/seek_sanity_test.c
>>> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>>> goto out;
>>>
>>> for (i = 0; i< numtests; ++i) {
>>> + ret = run_test(&seek_tests[i]);
>>> if (ret)
>>> - goto out;
>>> - run_test(&seek_tests[i]);
>>> + break;
>>> }
>>>
>>> out:
>>> --
>>> 1.7.12.rc2.18.g61b472e
>>>
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
> Hi Jeff and Zheng,
>
> Jeff, can I assume by your email:
>
> http://oss.sgi.com/archives/xfs/2012-10/msg00412.html
>
> that you are giving your Reviewed-by:?
Hi Mark,
Sure, it looks good to me. :)
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
>
> It also looks good to me too:
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
>
> I will make sure it gets committed.
>
> --Mark.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] xfstests: get return value in seek_sanity_test
2012-10-21 13:15 [PATCH v2] xfstests: get return value in seek_sanity_test wenqing.lz
2012-10-21 13:13 ` Jie Liu
2012-11-09 3:25 ` Zheng Liu
@ 2012-11-20 15:26 ` Mark Tinguely
2 siblings, 0 replies; 7+ messages in thread
From: Mark Tinguely @ 2012-11-20 15:26 UTC (permalink / raw)
To: wenqing.lz; +Cc: Jeff Liu, Zheng Liu, xfs
On 10/21/12 08:15, wenqing.lz wrote:
> From: Zheng Liu<wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing. Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> CC: Jeff Liu<jeff.liu@oracle.com>
> Signed-off-by: Zheng Liu<wenqing.lz@taobao.com>
> ---
> v2<- v1:
> * put return value check below the run_test()
This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests
master branch, commit 7eab7e.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-20 15:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-21 13:15 [PATCH v2] xfstests: get return value in seek_sanity_test wenqing.lz
2012-10-21 13:13 ` Jie Liu
2012-11-09 3:25 ` Zheng Liu
2012-11-09 5:38 ` Jeff Liu
2012-11-09 14:30 ` Mark Tinguely
2012-11-17 6:06 ` Jeff Liu
2012-11-20 15:26 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox