Re: [PATCH v2] xfstests: get return value in seek_sanity_test

Jeff Liu
2012-11-17T06:04:44Z

On 11/09/2012 10:30 PM, Mark Tinguely wrote:
> On 11/08/12 21:25, Zheng Liu wrote:
>> On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:
>>
>> ping?
>>
>> Regards,
>> Zheng
>>
>>> From: Zheng Liu<wenqing.lz@taobao.com>
>>>
>>> In seek_sanity_test getting return value is missing. Thus we couldn't get the
>>> result unless someone read the log file (e.g. # 285).
>>>
>>> CC: Jeff Liu<jeff.liu@oracle.com>
>>> Signed-off-by: Zheng Liu<wenqing.lz@taobao.com>
>>> ---
>>> v2<- v1:
>>> * put return value check below the run_test()
>>>
>>> Hi Jeff,
>>>
>>> Could you please review this patch again? Thanks.
>>>
>>> Regards,
>>> Zheng
>>>
>>> src/seek_sanity_test.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
>>> index 34f5508..3897f02 100644
>>> --- a/src/seek_sanity_test.c
>>> +++ b/src/seek_sanity_test.c
>>> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>>> goto out;
>>>
>>> for (i = 0; i< numtests; ++i) {
>>> + ret = run_test(&seek_tests[i]);
>>> if (ret)
>>> - goto out;
>>> - run_test(&seek_tests[i]);
>>> + break;
>>> }
>>>
>>> out:
>>> --
>>> 1.7.12.rc2.18.g61b472e
>>>
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
> Hi Jeff and Zheng,
>
> Jeff, can I assume by your email:
>
> http://oss.sgi.com/archives/xfs/2012-10/msg00412.html
>
> that you are giving your Reviewed-by:?
Hi Mark,

Sure, it looks good to me. :)

Reviewed-by: Jie Liu <jeff.liu@oracle.com>

Thanks,
-Jeff
>
> It also looks good to me too:
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
>
> I will make sure it gets committed.
>
> --Mark.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs