public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: XFS AG disk layout described on official doc is wrong
Date: Fri, 09 Nov 2012 15:45:58 +0800	[thread overview]
Message-ID: <509CB4B6.10408@oracle.com> (raw)
In-Reply-To: <20121109073654.GC6434@dastard>

On 11/09/2012 03:36 PM, Dave Chinner wrote:
> On Fri, Nov 09, 2012 at 02:47:41PM +0800, Jeff Liu wrote:
>> Hello,
>>
>> I observed that there is an issue on our official DOC for AG disk
>> layout, which can be found at:
>> http://xfs.org/docs/xfsdocs-xml-dev/XFS_Filesystem_Structure//tmp/en-US/html/Allocation_Groups.html
>>
>> It shows that the IBT block is followed by the block where AGFL sector
>> resides.  However, it should be followed by the
>> CNT block according to my debug, like below:
>>
>> -------------------------------
>> superblock
>> AG free block info
>> AG inode B+tree info
>> AG internal free list
>> -------------------------------
>> Root of free space B+tree
>>   B+tree key is block number
>> -------------------------------
>> Root of free space B+tree
>>   B+tree key is block count
>> --------------------------------
>> Root of inodes B+tree
>> --------------------------------
>>
>> Maybe the DOC is old, or am I missing anything?  If not, can we correct it?
> 
> The btree root blocks are dynamic. mkfs.xfs puts them in a fixed
> place, just like growfs does, but the moment you split a root block,
> it moves from that location. Hence the only way to reliably find the
> root btree block is to look up the point in the AGF/AGI, and that's
> what the document shows. IOWs, the ordering in the document is not
> important - the linkage is - as the root blocks can end up
> *anywhere* in the AG.
> 
> e.g:
> 
> $ sudo xfs_db -r -c "agf 0" -c p /dev/vda
> magicnum = 0x58414746
> versionnum = 1
> seqno = 0
> length = 262144
> bnoroot = 596
> cntroot = 1003
> bnolevel = 2
> cntlevel = 2
> ....
Ah, thanks for your quick response, now I understood. :)

Regards,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-11-09  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  6:47 XFS AG disk layout described on official doc is wrong Jeff Liu
2012-11-09  7:36 ` Dave Chinner
2012-11-09  7:45   ` Jeff Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509CB4B6.10408@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox