From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs_db: flush devices before exiting
Date: Tue, 13 Nov 2012 11:45:30 -0600 [thread overview]
Message-ID: <50A2873A.8080707@sgi.com> (raw)
In-Reply-To: <1352444578-14600-2-git-send-email-david@fromorbit.com>
On 11/09/12 01:02, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Test 287 uses xfs_db to change 32-bit project ID support while the
> filesystem is unmounted. On a large filesystem the test was failing
> due to the mount not seeing the feature bit in the superblock.
>
> xfs_db uses a different address space to the filesystem when it is
> mounte dby the kernel, so the only way to keep them coherent is to
> ensure that all buffered data is written to disk before the other
> entity tries to read it. xfs_db uses buffered IO, but does not close
> the devices when it exits, thereby leaving changes it has written in
> the block device cache rather than on disk. Hence when th ekernel
> tries to mount the filesystem, it reads what is on disk and does not
> see xfs_db's changes.
>
> Fix this by ensuring that xfs_db flushes it's changes to disk before
> it exits by caling libxfs_device_close(). This fsyncs the data and
> flushes the caches to ensure that it is present on disk before
> xfs_db exits.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Looks good. Consistent to mkfs.xfs and xfs_repair.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-13 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 7:02 [PATCH 0/2] xfsprogs: fixes for release candidate Dave Chinner
2012-11-09 7:02 ` [PATCH 1/2] xfs_db: flush devices before exiting Dave Chinner
2012-11-13 17:45 ` Mark Tinguely [this message]
2012-11-09 7:02 ` [PATCH 2/2] xfs_quota: fix report command parsing Dave Chinner
2012-11-13 18:02 ` Mark Tinguely
2012-11-12 23:22 ` [PATCH 0/2] xfsprogs: fixes for release candidate Dave Chinner
2012-11-20 23:17 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A2873A.8080707@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox