From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_quota: correctly initialise the default path
Date: Sat, 17 Nov 2012 15:15:25 -0600 [thread overview]
Message-ID: <50A7FE6D.6050206@sgi.com> (raw)
In-Reply-To: <1353028488-24436-1-git-send-email-david@fromorbit.com>
On 11/15/12 19:14, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> When we initial xfs_quota, we place lots of information into the
> fs_table. This includes all the devices/mount points the user has
> specified as a global command line parameter to report on, as well
> as all the paths under project quota control.
>
> There is a "current path" pointer (fs_path) maintained by the code
> that points somewhere into the fs_table. After the table is
> initialised, fs_path always points to the last entry in the table,
> and hence has to be re-initialised to point at the desired entry
> before it can be used properly.
...
fun code read :)
> init_commands();
> add_args_command(init_args_command);
> +
> + /*
> + * Ensure that global commands don't end up with an invalid path pointer
> + * by setting the default device at the first specified on the CLI
> + */
> + if (argc != optind)
> + fs_path = fs_table_lookup(argv[optind], FS_MOUNT_POINT);
fs_table_lookup() can return NULL - especially the way I type.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-17 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 1:14 [PATCH] xfs_quota: correctly initialise the default path Dave Chinner
2012-11-16 4:18 ` Eric Sandeen
2012-11-16 6:29 ` Dave Chinner
2012-11-17 21:15 ` Mark Tinguely [this message]
2012-11-20 3:41 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A7FE6D.6050206@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox