Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices

From: Eric Sandeen <sandeen@sandeen.net>
To: sat <takeuchi_satoru@jp.fujitsu.com>
Cc: Rich Johnston <rjohnston@sgi.com>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
Date: Mon, 19 Nov 2012 22:06:02 -0600	[thread overview]
Message-ID: <50AB01AA.5060706@sandeen.net> (raw)
In-Reply-To: <50A9A6FE.1080106@jp.fujitsu.com>

On 11/18/12 9:26 PM, sat wrote:
> Hi Rich, Eric
> 
> (2012/10/27 1:46), Rich Johnston wrote:
>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>> If you try running xfstests on lvm volumes which are symlinks,
>>> it'll fail to run several tests because our _require_scratch
>>> framework ultimately uses lstat not stat, and does not think
>>> the lvm device (which is usually a symlink to a dm-X device)
>>> is a block device.  Sigh.
>>>
>>> Last try at this - just resolve any symlinked devicenames
>>> into their realpath(3) in common.config.
>>>
>>> This actually seems to work.
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>
>>> ---
>>>
>>>
>>> diff --git a/common.config b/common.config
>>> index 926846b..e5b2483 100644
>>> --- a/common.config
>>> +++ b/common.config
>>
>> Looks good
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> Eric,
>>
>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
> 
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> 
> Commit d5ea873f is not the same as the the following original Eric's patch.
> 
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
> 
> It does not modify src/Makefile and realpath is never compiled.

Yep, whoops.  Merge error . . .?

> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.

Well, I don't think ./check will get very far with an undefined TEST_DEV or
SCRATCH_DEV, but better this way, thanks.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Rich Johnston <rjohnston@sgi.com>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> 
> ---
>  common.config |    4 ++--
>  src/Makefile  |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/common.config b/common.config
> index 585b150..3240ee9 100644
> --- a/common.config
> +++ b/common.config
> @@ -221,11 +221,11 @@ else
>  fi
>  
>  # Scripts just don't deal well with symlinked devices
> -if [ -L $TEST_DEV ]; then
> +if [ -L "$TEST_DEV" ]; then
>          TEST_DEV=`src/realpath $TEST_DEV`
>  fi
>  
> -if [ -L $SCRATCH_DEV ]; then
> +if [ -L "$SCRATCH_DEV" ]; then
>          SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
>  fi
>  
> diff --git a/src/Makefile b/src/Makefile
> index f7362a2..9f7281d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
>         devzero feature alloc fault fstest t_access_root \
>         godown resvtest writemod makeextents itrash rename \
>         multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
> -       t_mmap_writev
> +       t_mmap_writev realpath
>  
>  LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
>         preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs