From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qAK4TPRs098502 for ; Mon, 19 Nov 2012 22:29:26 -0600 Received: from fgwmail5.fujitsu.co.jp (fgwmail5.fujitsu.co.jp [192.51.44.35]) by cuda.sgi.com with ESMTP id f3Tq5lBZfAg3q7Gy (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 19 Nov 2012 20:31:34 -0800 (PST) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 4727A3EE0AE for ; Tue, 20 Nov 2012 13:31:32 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 2F5B845DE4D for ; Tue, 20 Nov 2012 13:31:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 14F4545DD74 for ; Tue, 20 Nov 2012 13:31:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 08CD71DB8038 for ; Tue, 20 Nov 2012 13:31:32 +0900 (JST) Received: from g01jpexchkw05.g01.fujitsu.local (g01jpexchkw05.g01.fujitsu.local [10.0.194.44]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id BC6D01DB802C for ; Tue, 20 Nov 2012 13:31:31 +0900 (JST) Message-ID: <50AB077F.5000003@jp.fujitsu.com> Date: Tue, 20 Nov 2012 13:30:55 +0900 From: sat MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices References: <4C0EA21B.8020703@sandeen.net> <508ABE75.4030703@sgi.com> <50A9A6FE.1080106@jp.fujitsu.com> <50AB01AA.5060706@sandeen.net> In-Reply-To: <50AB01AA.5060706@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Rich Johnston , xfs mailing list (2012/11/20 13:06), Eric Sandeen wrote: > On 11/18/12 9:26 PM, sat wrote: >> Hi Rich, Eric >> >> (2012/10/27 1:46), Rich Johnston wrote: >>> On 06/08/2010 03:03 PM, Eric Sandeen wrote: >>>> If you try running xfstests on lvm volumes which are symlinks, >>>> it'll fail to run several tests because our _require_scratch >>>> framework ultimately uses lstat not stat, and does not think >>>> the lvm device (which is usually a symlink to a dm-X device) >>>> is a block device. Sigh. >>>> >>>> Last try at this - just resolve any symlinked devicenames >>>> into their realpath(3) in common.config. >>>> >>>> This actually seems to work. >>>> >>>> Signed-off-by: Eric Sandeen >>>> >>>> --- >>>> >>>> >>>> diff --git a/common.config b/common.config >>>> index 926846b..e5b2483 100644 >>>> --- a/common.config >>>> +++ b/common.config >>> >>> Looks good >>> >>> Reviewed-by: Rich Johnston >>> >>> Eric, >>> >>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f. >> >> From: Satoru Takeuchi >> >> Commit d5ea873f is not the same as the the following original Eric's patch. >> >> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html >> >> It does not modify src/Makefile and realpath is never compiled. > > Yep, whoops. Merge error . . .? > >> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0 >> if $TEST_DEV or $SCRATCH_DEV are not defined. > > Well, I don't think ./check will get very far with an undefined TEST_DEV or > SCRATCH_DEV, but better this way, thanks. I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README). I forgot to specify $SCRATCH_DEV and found this problem. Satoru _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs