From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qARLETOq090469 for ; Tue, 27 Nov 2012 15:14:29 -0600 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id KVHSbQiKOrpklU97 for ; Tue, 27 Nov 2012 13:16:45 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARLGjin018247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 Nov 2012 16:16:45 -0500 Received: from liberator.sandeen.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qARLGeb9011081 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 27 Nov 2012 16:16:43 -0500 Message-ID: <50B52DB7.3030506@redhat.com> Date: Tue, 27 Nov 2012 15:16:39 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: [PATCH] xfstests: test EROFS vs. EEXIST when creating on an RO filesystem List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs-oss TBH, I don't know if this is posix-specified, but I found out the hard way that when trying to re-create existing files on a readonly filesystem, some apps expect/handle EEXIST, but fail on EROFS. This will test mkdir, mknod, and symlinks for that behavior. Signed-off-by: Eric Sandeen --- Note: Think the command output is fixed enough, or should I be grepping for keywords? diff --git a/292 b/292 new file mode 100755 index 0000000..a14bb7f --- /dev/null +++ b/292 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test No. 292 +# +# Tests for EEXIST (not EROFS) for inode creations, if +# we ask to create an already-existing entity on an RO filesystem +# +#----------------------------------------------------------------------- +# Copyright (c) 2012 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# +# creator +owner=sandeen@redhat.com + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch + +THIS_TEST_DIR=$SCRATCH_MNT/$seq.test + +_create_files() +{ + mknod $THIS_TEST_DIR/testnode c 1 3 + mkdir $THIS_TEST_DIR/testdir + touch $THIS_TEST_DIR/testtarget + ln -s $THIS_TEST_DIR/testtarget $THIS_TEST_DIR/testlink +} + +_scratch_mount + +rm -rf $THIS_TEST_DIR +mkdir $THIS_TEST_DIR || _fail "Could not create dir for test" + +_create_files 2>&1 | _filter_scratch +_scratch_mount -o remount,ro || _fail "Could not remount scratch readonly" +_create_files 2>&1 | _filter_scratch + +# success, all done +status=0 +exit diff --git a/292.out b/292.out new file mode 100644 index 0000000..485c567 --- /dev/null +++ b/292.out @@ -0,0 +1,5 @@ +QA output created by 292 +mknod: `SCRATCH_MNT/292.test/testnode': File exists +mkdir: cannot create directory `SCRATCH_MNT/292.test/testdir': File exists +touch: cannot touch `SCRATCH_MNT/292.test/testtarget': Read-only file system +ln: creating symbolic link `SCRATCH_MNT/292.test/testlink': File exists diff --git a/group b/group index dc8db65..030082b 100644 --- a/group +++ b/group @@ -410,3 +410,4 @@ deprecated 289 auto quick 290 auto rw prealloc quick ioctl 291 repair +292 auto quick _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs