From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qBA0Ksfu147744 for ; Sun, 9 Dec 2012 18:20:54 -0600 Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id wMtI09nFhjTj00QQ for ; Sun, 09 Dec 2012 16:23:22 -0800 (PST) Message-ID: <50C52B79.6010707@sandeen.net> Date: Sun, 09 Dec 2012 18:23:21 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode References: <50ABB115.9070905@sandeen.net> <20121121095636.GC23339@infradead.org> <50C115E8.9090106@sandeen.net> <20121208120007.GB4430@infradead.org> <50C36A83.1040406@sandeen.net> <20121209235105.GD15784@dastard> In-Reply-To: <20121209235105.GD15784@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Christoph Hellwig , Ben England , xfs-oss On 12/9/12 5:51 PM, Dave Chinner wrote: > On Sat, Dec 08, 2012 at 10:27:47AM -0600, Eric Sandeen wrote: >> On 12/8/12 6:00 AM, Christoph Hellwig wrote: >>> On Thu, Dec 06, 2012 at 04:02:16PM -0600, Eric Sandeen wrote: >>>> Ensure that when mkfs.xfs is invoked with commandline geometry, it >>>> triggers multidisk mode and creates more AGs. >>>> >>>> Signed-off-by: Eric Sandeen >>> >>> Looks good, >>> >>> Reviewed-by: Christoph Hellwig >> >> Thanks >> >>>> Maybe this should also test device-specified geometry, but not sure >>>> how to do that easily within xfstests, any ideas? >>> >>> That would involved scsi_debug so that we could set them up. We had >>> several ideas how to use scsi debug for these sort of tests but never >>> really bothered to do it. If you have some spare cycles I'd love to see >>> this sort of tests. >> >> scsi_debug won't report geometry on its own today; we'd need to assemble >> something out of scsi_debug luns I'm afraid, so it gets even more involved. >> >> We do have a little bit of scsi_debug framework in xfstests today, though, >> so if scsi_debug grew the capability it'd be easy to add. > > Does it really need scsi for this? To mkfs.xfs, all devices look the > same, so if you want to make random geometries, wouldn't playing > games with llopback devices and DM be sufficient? Yeah that'd be fine too. If scsi_debug could just generate geometries that'd be a bit easier. But it doesn't. -Eric > Cheers, > > Dave. > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs