From: Mark Tinguely <tinguely@sgi.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs: fix warning in libxcmd/input.c
Date: Fri, 01 Feb 2013 15:43:55 -0600 [thread overview]
Message-ID: <510C371B.6070300@sgi.com> (raw)
In-Reply-To: <20130201213649.GM30652@sgi.com>
On 02/01/13 15:36, Ben Myers wrote:
> Fix an error when building with -Werror=format-security.
>
> input.c: In function 'fetchline':
> input.c:91:2: error: format not a string literal and no format arguments [-Werror=format-security]
>
> Signed-off-by: Ben Myers<bpm@sgi.com>
> Reported by: Arkadiusz Miśkiewicz<arekm@maven.pl>
> Index: xfsprogs/libxcmd/input.c
> ===================================================================
> --- xfsprogs.orig/libxcmd/input.c 2013-02-01 15:29:47.069894522 -0600
> +++ xfsprogs/libxcmd/input.c 2013-02-01 15:30:00.845895188 -0600
> @@ -88,7 +88,7 @@
>
> if (!line)
> return NULL;
> - printf(get_prompt());
> + printf("%s", get_prompt());
> fflush(stdout);
> if (!fgets(line, MAXREADLINESZ, stdin)) {
> free(line);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-02-01 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 21:36 xfsprogs: fix warning in libxcmd/input.c Ben Myers
2013-02-01 21:43 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510C371B.6070300@sgi.com \
--to=tinguely@sgi.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox