From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Chandan Babu R <chandan.babu@oracle.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] xfs: remove unnecessary check
Date: Fri, 12 Jul 2024 17:34:14 +0000 [thread overview]
Message-ID: <512241eb-2190-40f4-aeae-066d67464362@nvidia.com> (raw)
In-Reply-To: <a6c945f8-b07c-4474-a603-ff360b8fb0f4@stanley.mountain>
On 7/12/2024 7:07 AM, Dan Carpenter wrote:
> We checked that "pip" is non-NULL at the start of the if else statement
> so there is no need to check again here. Delete the check.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@linaro.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2024-07-12 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 14:07 [PATCH] xfs: remove unnecessary check Dan Carpenter
2024-07-12 15:18 ` Darrick J. Wong
2024-07-12 17:34 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512241eb-2190-40f4-aeae-066d67464362@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=chandan.babu@oracle.com \
--cc=dan.carpenter@linaro.org \
--cc=djwong@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox