public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfstests: Add new standard loop handling functions
Date: Tue, 26 Feb 2013 09:32:17 -0600	[thread overview]
Message-ID: <512CD581.6000302@sgi.com> (raw)
In-Reply-To: <2102910196.6066385.1360050965047.JavaMail.root@redhat.com>

Add _create_loop_device and _destroy_loop_device to uniformly handle
loopback devices.

Signed-off-by: Tomas Racek <tracek@redhat.com>

>>
>> _create_loop_device()
>> {
>> 	dev=`losetup -f --show $file` || _fail "Cannot associate $file with
>> 	$dev"
>> 	echo $dev
>> }
>>

Looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-02-26 15:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03 10:19 [PATCH 1/3] xfstests: Provide dumpe2fs via standard common.config interface Tomas Racek
2013-02-03 10:19 ` [PATCH 2/3] xfstests: Add new standard loop handling functions Tomas Racek
2013-02-03 16:08   ` Eric Sandeen
2013-02-05  7:56     ` Tomas Racek
2013-02-26 15:32       ` Rich Johnston [this message]
2013-02-03 10:19 ` [PATCH 3/3 V2] xfstests: 297: Test that FS sends discard requests only on free blocks Tomas Racek
2013-02-26 15:32   ` Rich Johnston
2013-02-20 20:17 ` [PATCH 1/3] xfstests: Provide dumpe2fs via standard common.config interface Ben Myers
2013-02-26 15:44 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512CD581.6000302@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=lczerner@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=tracek@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox