From: Eric Sandeen <sandeen@sandeen.net>
To: Hans-Peter Jansen <hpj@urpla.net>
Cc: xfs@oss.sgi.com
Subject: Re: Fwd: xfs_reno
Date: Wed, 06 Mar 2013 14:37:36 -0600 [thread overview]
Message-ID: <5137A910.7090404@sandeen.net> (raw)
In-Reply-To: <20351675.Zy117sIl8Z@xrated>
On 3/6/13 8:55 AM, Hans-Peter Jansen wrote:
> Hi Dave,
>
> I tried to gather Barrys SOB, but failed so far. His trace ends in 2009 google
> wise.
I've got him. ;) I asked him to chime in here or maybe email you personally.
Thanks,
-Eric
> How is this case usually handled?
>
> Here's the current state of things.
>
> Cheers,
> Pete
>
>
> ---------- Weitergeleitete Nachricht ----------
>
> Betreff: xfs_reno
> Datum: Mittwoch, 6. März 2013, 12:52:19
> Von: Hans-Peter Jansen <hpj@urpla.net>
> An: bnaujok@sgi.com
>
> Hi Barry,
>
> attached is a slightly mangled version of your xfs_reno tool, that I badly
> needed recently. While at it, I plan to submit it, as it saved my *ss. Thanks.
>
> Apart from relocation to xfsprogs, I just changed this
>
> + log_message(LOG_DEBUG, "%s: %llu %lu %s", msg, node->ino,
> + node->numpaths, node->paths[0]);
>
> from %llu to %lu for the node->numpaths argument. It might still be wrong, as
> numpath is defined as nlink_t which is a __u32 type, but the %s printed
> garbage like this:
>
> Scanning directory tree...
> xfs_reno: add_node_path: ino 8611163235, path
> /work/dlbase/hosts/11.2/pico/var/run/screens
> xfs_reno: add_node_path: ino 8611163233, path
> /work/dlbase/hosts/11.2/pico/var/run/pcscd/pcscd.events
> xfs_reno: add_node_path: ino 8611163234, path
> /work/dlbase/hosts/11.2/pico/var/run/uscreens
> xfs_reno: nodehash: 8611163233 692488159933497345 ��]��f�e�
> xfs_reno: nodehash: 8611163234 692366801337581569 ��]��f�e�
> xfs_reno: nodehash: 8611163235 692223830466232321 ��]��f�e�
>
> I guess, gcc is smart enough to see, that the struct members overlap here, and
> prints the paths[0] argument as a %llu value. What do you think?
>
> Anyway, I will revise this during the course of creating a xlstests test for
> xfs_reno...
>
> Do you allow me to add your Signed-off-by to this patch?
>
> If you want to build this, apply both patches to xfsprogs.
>
> TIA,
> Pete
>
> -------------------------------------------------------------
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-06 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 14:55 Fwd: xfs_reno Hans-Peter Jansen
2013-03-06 20:37 ` Eric Sandeen [this message]
2013-03-07 4:13 ` Dave Chinner
2013-03-07 20:16 ` Ben Myers
2013-03-11 21:48 ` Mark Tinguely
2013-03-12 9:02 ` Hans-Peter Jansen
2013-03-12 13:48 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137A910.7090404@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hpj@urpla.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox