From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 0F3587F4C for ; Fri, 8 Mar 2013 14:31:12 -0600 (CST) Message-ID: <513A4A9B.3050802@sgi.com> Date: Fri, 8 Mar 2013 14:31:23 -0600 From: Rich Johnston MIME-Version: 1.0 Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode References: <51313DE8.5080104@sandeen.net> <51326DC0.8030403@sandeen.net> In-Reply-To: <51326DC0.8030403@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Ole Tange , xfs-oss This version looks good. ;) Reviewed-by: Rich Johnston This has been committed. commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96 Author: Eric Sandeen Date: Sat Mar 2 21:23:12 2013 +0000 xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up bad freelist blocks that it finds. When we get to scan_freelist, this can wreak havoc if, for example, first > last and the loop never exits; we index agfl->agfl_bno[i] off into the weeds. To fix this, re-check the values in no-modify mode, and if they're off, warn about it and skip the scan. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs