From: Eric Sandeen <sandeen@sandeen.net>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>, Ole Tange <tange@binf.ku.dk>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
Date: Sat, 09 Mar 2013 09:00:55 -0600 [thread overview]
Message-ID: <513B4EA7.4060908@sandeen.net> (raw)
In-Reply-To: <513A4A9B.3050802@sgi.com>
On 3/8/13 2:31 PM, Rich Johnston wrote:
> This version looks good. ;)
Actually it's not quite:
scan.c: In function ‘scan_freelist’:
scan.c:1074: warning: ‘i’ may be used uninitialized in this function
I don't know what's wrong with my brain these days. :/
I will send a patch to fix that along w/ the other scan_freelists shortly.
Sorry :/
-Eric
> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
> This has been committed.
>
> commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96
> Author: Eric Sandeen <sandeen@sandeen.net>
> Date: Sat Mar 2 21:23:12 2013 +0000
>
> xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode
>
> In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up
> bad freelist blocks that it finds. When we get to scan_freelist,
> this can wreak havoc if, for example, first > last and the loop
> never exits; we index agfl->agfl_bno[i] off into the weeds.
>
> To fix this, re-check the values in no-modify mode, and if
> they're off, warn about it and skip the scan.
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-09 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 23:46 [PATCH] xfs_repair: skip freelist scan of dodgy agf in no-modify mode Eric Sandeen
2013-03-02 1:18 ` Dave Chinner
2013-03-02 1:22 ` Eric Sandeen
2013-03-02 21:23 ` [PATCH V2] xfs_repair: skip freelist scan of corrupt " Eric Sandeen
2013-03-03 23:36 ` Dave Chinner
2013-03-08 20:31 ` Rich Johnston
2013-03-08 20:31 ` Eric Sandeen
2013-03-09 9:00 ` Dave Chinner
2013-03-11 12:20 ` Rich Johnston
2013-03-09 15:00 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513B4EA7.4060908@sandeen.net \
--to=sandeen@sandeen.net \
--cc=rjohnston@sgi.com \
--cc=tange@binf.ku.dk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox