Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode

Rich Johnston
2013-03-11T12:20:19Z

On 03/09/2013 03:00 AM, Dave Chinner wrote:
> On Fri, Mar 08, 2013 at 02:31:23PM -0600, Rich Johnston wrote:
>> This version looks good. ;)
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> This has been committed.
>
> Except that all review comments have not been addressed. i.e there
> are two places that have the same bug and they haven't been fixed.
>
> It's great that you want to commit quickly, but commits should not
> happen while there are unaddressed issues still outstanding....

Sorry Dave I misunderstood your comments. I took them to mean you were
going to make those changes with your CRC patch. I will make sure to
clarify before committing.

>
> Cheers,
>
> Dave.