Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode

Eric Sandeen
2013-03-09T15:00:58Z

On 3/8/13 2:31 PM, Rich Johnston wrote:
> This version looks good. ;)

Actually it's not quite:

scan.c: In function ‘scan_freelist’:
scan.c:1074: warning: ‘i’ may be used uninitialized in this function

I don't know what's wrong with my brain these days. :/

I will send a patch to fix that along w/ the other scan_freelists shortly.

Sorry :/

-Eric

> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
> This has been committed.
>
> commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96
> Author: Eric Sandeen <sandeen@sandeen.net>
> Date: Sat Mar 2 21:23:12 2013 +0000
>
> xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode
>
> In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up
> bad freelist blocks that it finds. When we get to scan_freelist,
> this can wreak havoc if, for example, first > last and the loop
> never exits; we index agfl->agfl_bno[i] off into the weeds.
>
> To fix this, re-check the values in no-modify mode, and if
> they're off, warn about it and skip the scan.
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs