From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>, Eric Sandeen <sandeen@sandeen.net>,
Ole Tange <tange@binf.ku.dk>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
Date: Mon, 11 Mar 2013 07:20:35 -0500 [thread overview]
Message-ID: <513DCC13.6050800@sgi.com> (raw)
In-Reply-To: <20130309090041.GG23616@dastard>
On 03/09/2013 03:00 AM, Dave Chinner wrote:
> On Fri, Mar 08, 2013 at 02:31:23PM -0600, Rich Johnston wrote:
>> This version looks good. ;)
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> This has been committed.
>
> Except that all review comments have not been addressed. i.e there
> are two places that have the same bug and they haven't been fixed.
>
> It's great that you want to commit quickly, but commits should not
> happen while there are unaddressed issues still outstanding....
Sorry Dave I misunderstood your comments. I took them to mean you were
going to make those changes with your CRC patch. I will make sure to
clarify before committing.
>
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-11 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 23:46 [PATCH] xfs_repair: skip freelist scan of dodgy agf in no-modify mode Eric Sandeen
2013-03-02 1:18 ` Dave Chinner
2013-03-02 1:22 ` Eric Sandeen
2013-03-02 21:23 ` [PATCH V2] xfs_repair: skip freelist scan of corrupt " Eric Sandeen
2013-03-03 23:36 ` Dave Chinner
2013-03-08 20:31 ` Rich Johnston
2013-03-08 20:31 ` Eric Sandeen
2013-03-09 9:00 ` Dave Chinner
2013-03-11 12:20 ` Rich Johnston [this message]
2013-03-09 15:00 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DCC13.6050800@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=tange@binf.ku.dk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox