From: Mark Tinguely <tinguely@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: dchinner@redhat.com, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure
Date: Mon, 11 Mar 2013 12:59:18 -0500 [thread overview]
Message-ID: <513E1B76.2090808@sgi.com> (raw)
In-Reply-To: <513D7A26.3030401@oracle.com>
On 03/11/13 01:31, Jeff Liu wrote:
> Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via
> m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> Cc: Dave Chinner<dchinner@redhat.com>
> ---
> fs/xfs/xfs_mount.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index bc90706..687c171 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -207,7 +207,6 @@ typedef struct xfs_mount {
> trimming */
> __int64_t m_update_flags; /* sb flags we need to update
> on the next remount,rw */
> - struct shrinker m_inode_shrink; /* inode reclaim shrinker */
> int64_t m_low_space[XFS_LOWSP_MAX];
> /* low free space thresholds */
>
Obsoleted in commit:
commit 8daaa83145ef1f0a146680618328dbbd0fa76939
Author: Dave Chinner <dchinner@redhat.com>
Date: Fri Jul 8 14:14:46 2011 +1000
xfs: make use of new shrinker callout for the inode cache
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-11 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 6:31 [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure Jeff Liu
2013-03-11 17:59 ` Mark Tinguely [this message]
2013-03-14 21:40 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513E1B76.2090808@sgi.com \
--to=tinguely@sgi.com \
--cc=dchinner@redhat.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox