public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure
@ 2013-03-11  6:31 Jeff Liu
  2013-03-11 17:59 ` Mark Tinguely
  2013-03-14 21:40 ` Ben Myers
  0 siblings, 2 replies; 3+ messages in thread
From: Jeff Liu @ 2013-03-11  6:31 UTC (permalink / raw)
  To: xfs@oss.sgi.com; +Cc: dchinner

Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via
m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Cc: Dave Chinner <dchinner@redhat.com>
---
 fs/xfs/xfs_mount.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index bc90706..687c171 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -207,7 +207,6 @@ typedef struct xfs_mount {
 						     trimming */
 	__int64_t		m_update_flags;	/* sb flags we need to update
 						   on the next remount,rw */
-	struct shrinker		m_inode_shrink;	/* inode reclaim shrinker */
 	int64_t			m_low_space[XFS_LOWSP_MAX];
 						/* low free space thresholds */
 
-- 
1.7.9.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure
  2013-03-11  6:31 [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure Jeff Liu
@ 2013-03-11 17:59 ` Mark Tinguely
  2013-03-14 21:40 ` Ben Myers
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2013-03-11 17:59 UTC (permalink / raw)
  To: Jeff Liu; +Cc: dchinner, xfs@oss.sgi.com

On 03/11/13 01:31, Jeff Liu wrote:
> Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via
> m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> Cc: Dave Chinner<dchinner@redhat.com>
> ---
>   fs/xfs/xfs_mount.h |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index bc90706..687c171 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -207,7 +207,6 @@ typedef struct xfs_mount {
>   						     trimming */
>   	__int64_t		m_update_flags;	/* sb flags we need to update
>   						   on the next remount,rw */
> -	struct shrinker		m_inode_shrink;	/* inode reclaim shrinker */
>   	int64_t			m_low_space[XFS_LOWSP_MAX];
>   						/* low free space thresholds */
>

Obsoleted in commit:

commit 8daaa83145ef1f0a146680618328dbbd0fa76939
Author: Dave Chinner <dchinner@redhat.com>
Date:   Fri Jul 8 14:14:46 2011 +1000

     xfs: make use of new shrinker callout for the inode cache

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure
  2013-03-11  6:31 [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure Jeff Liu
  2013-03-11 17:59 ` Mark Tinguely
@ 2013-03-14 21:40 ` Ben Myers
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2013-03-14 21:40 UTC (permalink / raw)
  To: Jeff Liu; +Cc: dchinner, xfs@oss.sgi.com

On Mon, Mar 11, 2013 at 02:31:02PM +0800, Jeff Liu wrote:
> Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via
> m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.
> 
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> Cc: Dave Chinner <dchinner@redhat.com>

Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-14 21:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11  6:31 [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure Jeff Liu
2013-03-11 17:59 ` Mark Tinguely
2013-03-14 21:40 ` Ben Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox