[PATCH] xfstests: determine path of logger

[PATCH] xfstests: determine path of logger

[David Sterba]

The path of the syslog writer utility 'logger' is hardcoded and not
always correct, use set_prog_path.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 check         | 2 +-
 common.config | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/check b/check
index c20179c..9a5b256 100755
--- a/check
+++ b/check
@@ -243,7 +243,7 @@ do
 	start=`_wallclock`
 	$timestamp && echo -n "	["`date "+%T"`"]"
 	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
-	[ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
+	$LOGGER_PROG "run xfstest $seq"
 	./$seq >$tmp.rawout 2>&1
 	sts=$?
 	$timestamp && _timestamp
diff --git a/common.config b/common.config
index a0b017d..ed0f44c 100644
--- a/common.config
+++ b/common.config
@@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
 export FIO_PROG="`set_prog_path fio`"
 export FILEFRAG_PROG="`set_prog_path filefrag`"
 export E4DEFRAG_PROG="`set_prog_path e4defrag`"
+export LOGGER_PROG="`set_prog_path logger`"
 
 # Generate a comparable xfsprogs version number in the form of
 # major * 10000 + minor * 100 + release
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: determine path of logger

[Dave Chinner]

On Tue, Mar 12, 2013 at 12:36:52AM +0100, David Sterba wrote:
> The path of the syslog writer utility 'logger' is hardcoded and not
> always correct, use set_prog_path.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
>  check         | 2 +-
>  common.config | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index c20179c..9a5b256 100755
> --- a/check
> +++ b/check
> @@ -243,7 +243,7 @@ do
>  	start=`_wallclock`
>  	$timestamp && echo -n "	["`date "+%T"`"]"
>  	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> -	[ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
> +	$LOGGER_PROG "run xfstest $seq"
>  	./$seq >$tmp.rawout 2>&1
>  	sts=$?
>  	$timestamp && _timestamp
> diff --git a/common.config b/common.config
> index a0b017d..ed0f44c 100644
> --- a/common.config
> +++ b/common.config
> @@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
>  export FIO_PROG="`set_prog_path fio`"
>  export FILEFRAG_PROG="`set_prog_path filefrag`"
>  export E4DEFRAG_PROG="`set_prog_path e4defrag`"
> +export LOGGER_PROG="`set_prog_path logger`"
>  
>  # Generate a comparable xfsprogs version number in the form of
>  # major * 10000 + minor * 100 + release

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: determine path of logger

[Rich Johnston]

This patch has been committed.

Regards
--Rich

commit 9958693bdb282adc422bcf85f5360e3a5785e8e9
Author: David Sterba <dsterba@suse.cz>
Date:   Mon Mar 11 23:36:52 2013 +0000

     xfstests: determine path of logger

     The path of the syslog writer utility 'logger' is hardcoded and not
     always correct, use set_prog_path.

     Signed-off-by: David Sterba <dsterba@suse.cz>
     Reviewed-by: Dave Chinner <dchinner@redhat.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs