From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 4C0597F83 for ; Tue, 12 Mar 2013 09:40:25 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 297C58F8035 for ; Tue, 12 Mar 2013 07:40:21 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id 8f8oX6ShBLLQKNLY for ; Tue, 12 Mar 2013 07:40:17 -0700 (PDT) Message-ID: <513F3E51.7000600@sandeen.net> Date: Tue, 12 Mar 2013 09:40:17 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: xfs_repair segfaults References: <512FA67D.2090708@sandeen.net> <5130DB54.9030503@sandeen.net> <5134BBA4.3060305@sandeen.net> <513A4AEC.4010202@sandeen.net> In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ole Tange Cc: xfs@oss.sgi.com On 3/12/13 5:41 AM, Ole Tange wrote: > On Fri, Mar 8, 2013 at 9:32 PM, Eric Sandeen wrote: >> On 3/8/13 4:21 AM, Ole Tange wrote: >>> On Mon, Mar 4, 2013 at 4:20 PM, Eric Sandeen wrote: >>> >>>> 2) so you could run a "real" non-"n" xfs_repair on a metadata image as a more realistic dry run > : >>> I get >>> filenames like: >>> >>> /mnt/disk/??5?z+hEOgl/?7?Psr1?aIHS??+??z=ozK/8_0/???d) >>> 5JCG?eiBd?EVsNF'A?v?m?f;Fi6v)d>/?M%?A??J?)B>> X[Df?Wm^[?f 4| >> >> By default, xfs_metadump scrambles filenames, so nothing to worry >> about (it's for privacy reasons). If you use the "-o" option it'll keep >> it in the clear. > > Ahh. To me that does not conform to Principle of Least Astonishment - > especially since some of the filenames were not obfuscated. > > I would have been less surprised if the files were named: > > Use_-o_for_real_file_names_XXXXXXXX > Use_-o_for_real_dir_names_XXXXXXXX > > where XXXXXXXX is just a unique number. That would completely change the actual on-disk metadata format, though, which would defeat the primary purpose of metadump. As it is, it preserves name lengths and name hashes, so that what is produced is an accurate representation of the original filesystem's metadata for analysis. This is described in the manpage, though I sympathize that it's a bit alarming the first time you see it in the dump output, if you weren't aware. -Eric > > /Ole > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs