[PATCH] xfs_repair: remove unconditional ASSERT(0)

[PATCH] xfs_repair: remove unconditional ASSERT(0)

[Eric Sandeen]

I don't know what I was thinking in 7e8e3cc, but I added an
ASSERT(0) in the main path.  Obviously this isn't right.

Just remove it.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Really sorry, no idea what is up w/ my brain lately.
Trying to do too many things at once, too quickly.

diff --git a/repair/scan.c b/repair/scan.c
index 6a62dff..76bb7f1 100644
--- a/repair/scan.c
+++ b/repair/scan.c
@@ -1076,8 +1076,7 @@ scan_freelist(
 				  "freelist scan\n"), i);
 			return;
 		}
-	} else /* should have been fixed in verify_set_agf() */
-		ASSERT(0);
+	}
 
 	count = 0;
 	for (;;) {

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: remove unconditional ASSERT(0)

[Rich Johnston]

On 03/12/2013 09:50 AM, Eric Sandeen wrote:
> I don't know what I was thinking in 7e8e3cc, but I added an
> ASSERT(0) in the main path.  Obviously this isn't right.
>
> Just remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Really sorry, no idea what is up w/ my brain lately.
> Trying to do too many things at once, too quickly.
>
I can relate.  Thanks for the quick fix.

Looks good:

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

This has been committed.

Thanks
--Rich

commit b326e067f1005d584bd8ad21bb9f3e2700230e29
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Tue Mar 12 14:50:21 2013 +0000

     xfsprogs xfs_repair: remove unconditional ASSERT(0)

     I don't know what I was thinking in 7e8e3cc, but I added an
     ASSERT(0) in the main path.  Obviously this isn't right.

     Just remove it.

     Signed-off-by: Eric Sandeen <sandeen@redhat.com>
     Reviewed-by: Rich Johnston <rjohnston@sgi.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs