public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: remove unconditional ASSERT(0)
Date: Tue, 12 Mar 2013 10:44:54 -0500	[thread overview]
Message-ID: <513F4D76.5000600@sgi.com> (raw)
In-Reply-To: <513F40AD.10303@sandeen.net>


On 03/12/2013 09:50 AM, Eric Sandeen wrote:
> I don't know what I was thinking in 7e8e3cc, but I added an
> ASSERT(0) in the main path.  Obviously this isn't right.
>
> Just remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Really sorry, no idea what is up w/ my brain lately.
> Trying to do too many things at once, too quickly.
>
I can relate.  Thanks for the quick fix.

Looks good:

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

This has been committed.

Thanks
--Rich

commit b326e067f1005d584bd8ad21bb9f3e2700230e29
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Tue Mar 12 14:50:21 2013 +0000

     xfsprogs xfs_repair: remove unconditional ASSERT(0)

     I don't know what I was thinking in 7e8e3cc, but I added an
     ASSERT(0) in the main path.  Obviously this isn't right.

     Just remove it.

     Signed-off-by: Eric Sandeen <sandeen@redhat.com>
     Reviewed-by: Rich Johnston <rjohnston@sgi.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-03-12 15:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 14:50 [PATCH] xfs_repair: remove unconditional ASSERT(0) Eric Sandeen
2013-03-12 15:44 ` Rich Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513F4D76.5000600@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox