From: Eric Sandeen <sandeen@sandeen.net>
To: Rich Johnston <rjohnston@sgi.com>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: properly set Parent's PID
Date: Tue, 12 Mar 2013 23:09:49 -0500 [thread overview]
Message-ID: <513FFC0D.3030705@sandeen.net> (raw)
In-Reply-To: <513F58FE.1010200@sgi.com>
On 3/12/13 11:34 AM, Rich Johnston wrote:
> On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
>> Set parentpid variable to the correct Parent's ID using getppid() instead of
>> getpid()
>>
>> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
>> ---
>> common/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/main.c b/common/main.c
>> index 980d2d4..848a887 100644
>> --- a/common/main.c
>> +++ b/common/main.c
>> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
>> /* Get the parent's pid. will be used in signal handling
>> * to differentiate parent from children.
>> */
>> - parentpid = getpid( );
>> + parentpid = getppid( );
>> rval = atexit(mlog_exit_flush);
>> assert(rval == 0);
>>
>>
> Sorry for the late review, this does not apply to current xfsdump tree.
Hm, and hasn't since 2011. ;)
2da84e5d changed this:
* to differentiate parent from children.
*/
- parentpid = getpid( );
+ parenttid = pthread_self( );
Carlos, was this maybe against an older tree or released version?
-Eric
> Regards
> --Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-13 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 20:13 [PATCH] xfsdump: properly set Parent's PID Carlos Maiolino
2013-03-12 16:34 ` Rich Johnston
2013-03-13 4:09 ` Eric Sandeen [this message]
2013-03-13 12:46 ` Carlos Maiolino
2013-03-13 12:58 ` Carlos Maiolino
2013-03-13 13:39 ` Eric Sandeen
2013-03-18 13:21 ` Christoph Hellwig
2013-03-18 14:12 ` Eric Sandeen
2013-03-18 17:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513FFC0D.3030705@sandeen.net \
--to=sandeen@sandeen.net \
--cc=cmaiolino@redhat.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox