* [PATCH] xfsdump: properly set Parent's PID
@ 2013-01-31 20:13 Carlos Maiolino
2013-03-12 16:34 ` Rich Johnston
0 siblings, 1 reply; 9+ messages in thread
From: Carlos Maiolino @ 2013-01-31 20:13 UTC (permalink / raw)
To: xfs
Set parentpid variable to the correct Parent's ID using getppid() instead of
getpid()
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
common/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/main.c b/common/main.c
index 980d2d4..848a887 100644
--- a/common/main.c
+++ b/common/main.c
@@ -198,7 +198,7 @@ main( int argc, char *argv[] )
/* Get the parent's pid. will be used in signal handling
* to differentiate parent from children.
*/
- parentpid = getpid( );
+ parentpid = getppid( );
rval = atexit(mlog_exit_flush);
assert(rval == 0);
--
1.8.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-01-31 20:13 [PATCH] xfsdump: properly set Parent's PID Carlos Maiolino
@ 2013-03-12 16:34 ` Rich Johnston
2013-03-13 4:09 ` Eric Sandeen
0 siblings, 1 reply; 9+ messages in thread
From: Rich Johnston @ 2013-03-12 16:34 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: xfs
On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
> Set parentpid variable to the correct Parent's ID using getppid() instead of
> getpid()
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> common/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/main.c b/common/main.c
> index 980d2d4..848a887 100644
> --- a/common/main.c
> +++ b/common/main.c
> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
> /* Get the parent's pid. will be used in signal handling
> * to differentiate parent from children.
> */
> - parentpid = getpid( );
> + parentpid = getppid( );
> rval = atexit(mlog_exit_flush);
> assert(rval == 0);
>
>
Sorry for the late review, this does not apply to current xfsdump tree.
Regards
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-12 16:34 ` Rich Johnston
@ 2013-03-13 4:09 ` Eric Sandeen
2013-03-13 12:46 ` Carlos Maiolino
0 siblings, 1 reply; 9+ messages in thread
From: Eric Sandeen @ 2013-03-13 4:09 UTC (permalink / raw)
To: Rich Johnston; +Cc: Carlos Maiolino, xfs
On 3/12/13 11:34 AM, Rich Johnston wrote:
> On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
>> Set parentpid variable to the correct Parent's ID using getppid() instead of
>> getpid()
>>
>> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
>> ---
>> common/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/main.c b/common/main.c
>> index 980d2d4..848a887 100644
>> --- a/common/main.c
>> +++ b/common/main.c
>> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
>> /* Get the parent's pid. will be used in signal handling
>> * to differentiate parent from children.
>> */
>> - parentpid = getpid( );
>> + parentpid = getppid( );
>> rval = atexit(mlog_exit_flush);
>> assert(rval == 0);
>>
>>
> Sorry for the late review, this does not apply to current xfsdump tree.
Hm, and hasn't since 2011. ;)
2da84e5d changed this:
* to differentiate parent from children.
*/
- parentpid = getpid( );
+ parenttid = pthread_self( );
Carlos, was this maybe against an older tree or released version?
-Eric
> Regards
> --Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-13 4:09 ` Eric Sandeen
@ 2013-03-13 12:46 ` Carlos Maiolino
2013-03-13 12:58 ` Carlos Maiolino
0 siblings, 1 reply; 9+ messages in thread
From: Carlos Maiolino @ 2013-03-13 12:46 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Rich Johnston, xfs
Weird, I git pull'ed the repository before add the patch, I'll review my
origin's URL, sorry about that
On Tue, Mar 12, 2013 at 11:09:49PM -0500, Eric Sandeen wrote:
> On 3/12/13 11:34 AM, Rich Johnston wrote:
> > On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
> >> Set parentpid variable to the correct Parent's ID using getppid() instead of
> >> getpid()
> >>
> >> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> >> ---
> >> common/main.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/common/main.c b/common/main.c
> >> index 980d2d4..848a887 100644
> >> --- a/common/main.c
> >> +++ b/common/main.c
> >> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
> >> /* Get the parent's pid. will be used in signal handling
> >> * to differentiate parent from children.
> >> */
> >> - parentpid = getpid( );
> >> + parentpid = getppid( );
> >> rval = atexit(mlog_exit_flush);
> >> assert(rval == 0);
> >>
> >>
> > Sorry for the late review, this does not apply to current xfsdump tree.
>
> Hm, and hasn't since 2011. ;)
>
> 2da84e5d changed this:
>
> * to differentiate parent from children.
> */
> - parentpid = getpid( );
> + parenttid = pthread_self( );
>
> Carlos, was this maybe against an older tree or released version?
>
> -Eric
>
> > Regards
> > --Rich
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-13 12:46 ` Carlos Maiolino
@ 2013-03-13 12:58 ` Carlos Maiolino
2013-03-13 13:39 ` Eric Sandeen
0 siblings, 1 reply; 9+ messages in thread
From: Carlos Maiolino @ 2013-03-13 12:58 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Rich Johnston, xfs
Ah, my origin was pointing to the git.kernel.org xfsdump repository =[
On Wed, Mar 13, 2013 at 09:46:52AM -0300, Carlos Maiolino wrote:
> Weird, I git pull'ed the repository before add the patch, I'll review my
> origin's URL, sorry about that
>
> On Tue, Mar 12, 2013 at 11:09:49PM -0500, Eric Sandeen wrote:
> > On 3/12/13 11:34 AM, Rich Johnston wrote:
> > > On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
> > >> Set parentpid variable to the correct Parent's ID using getppid() instead of
> > >> getpid()
> > >>
> > >> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > >> ---
> > >> common/main.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/common/main.c b/common/main.c
> > >> index 980d2d4..848a887 100644
> > >> --- a/common/main.c
> > >> +++ b/common/main.c
> > >> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
> > >> /* Get the parent's pid. will be used in signal handling
> > >> * to differentiate parent from children.
> > >> */
> > >> - parentpid = getpid( );
> > >> + parentpid = getppid( );
> > >> rval = atexit(mlog_exit_flush);
> > >> assert(rval == 0);
> > >>
> > >>
> > > Sorry for the late review, this does not apply to current xfsdump tree.
> >
> > Hm, and hasn't since 2011. ;)
> >
> > 2da84e5d changed this:
> >
> > * to differentiate parent from children.
> > */
> > - parentpid = getpid( );
> > + parenttid = pthread_self( );
> >
> > Carlos, was this maybe against an older tree or released version?
> >
> > -Eric
> >
> > > Regards
> > > --Rich
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
>
> --
> Carlos
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-13 12:58 ` Carlos Maiolino
@ 2013-03-13 13:39 ` Eric Sandeen
2013-03-18 13:21 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: Eric Sandeen @ 2013-03-13 13:39 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: Christoph Hellwig, Rich Johnston, xfs
On 3/13/13 7:58 AM, Carlos Maiolino wrote:
> Ah, my origin was pointing to the git.kernel.org xfsdump repository =[
hch, can we please do something to those repos to make them more obviously
deprecated?
Thanks,
-Eric
> On Wed, Mar 13, 2013 at 09:46:52AM -0300, Carlos Maiolino wrote:
>> Weird, I git pull'ed the repository before add the patch, I'll review my
>> origin's URL, sorry about that
>>
>> On Tue, Mar 12, 2013 at 11:09:49PM -0500, Eric Sandeen wrote:
>>> On 3/12/13 11:34 AM, Rich Johnston wrote:
>>>> On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
>>>>> Set parentpid variable to the correct Parent's ID using getppid() instead of
>>>>> getpid()
>>>>>
>>>>> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
>>>>> ---
>>>>> common/main.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/common/main.c b/common/main.c
>>>>> index 980d2d4..848a887 100644
>>>>> --- a/common/main.c
>>>>> +++ b/common/main.c
>>>>> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
>>>>> /* Get the parent's pid. will be used in signal handling
>>>>> * to differentiate parent from children.
>>>>> */
>>>>> - parentpid = getpid( );
>>>>> + parentpid = getppid( );
>>>>> rval = atexit(mlog_exit_flush);
>>>>> assert(rval == 0);
>>>>>
>>>>>
>>>> Sorry for the late review, this does not apply to current xfsdump tree.
>>>
>>> Hm, and hasn't since 2011. ;)
>>>
>>> 2da84e5d changed this:
>>>
>>> * to differentiate parent from children.
>>> */
>>> - parentpid = getpid( );
>>> + parenttid = pthread_self( );
>>>
>>> Carlos, was this maybe against an older tree or released version?
>>>
>>> -Eric
>>>
>>>> Regards
>>>> --Rich
>>>
>>> _______________________________________________
>>> xfs mailing list
>>> xfs@oss.sgi.com
>>> http://oss.sgi.com/mailman/listinfo/xfs
>>
>> --
>> Carlos
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-13 13:39 ` Eric Sandeen
@ 2013-03-18 13:21 ` Christoph Hellwig
2013-03-18 14:12 ` Eric Sandeen
0 siblings, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2013-03-18 13:21 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, Rich Johnston, Carlos Maiolino, xfs
On Wed, Mar 13, 2013 at 08:39:46AM -0500, Eric Sandeen wrote:
> On 3/13/13 7:58 AM, Carlos Maiolino wrote:
> > Ah, my origin was pointing to the git.kernel.org xfsdump repository =[
>
> hch, can we please do something to those repos to make them more obviously
> deprecated?
Sorry, I totally forgot about that. I'll take care of it as soon as I
get close to the kernel.org PGP key again which I usually keep in a
physically safe place. Alternatively any other member of the xfs
group on kernel.org could take care of it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-18 13:21 ` Christoph Hellwig
@ 2013-03-18 14:12 ` Eric Sandeen
2013-03-18 17:13 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: Eric Sandeen @ 2013-03-18 14:12 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Rich Johnston, Carlos Maiolino, xfs
On 3/18/13 8:21 AM, Christoph Hellwig wrote:
> On Wed, Mar 13, 2013 at 08:39:46AM -0500, Eric Sandeen wrote:
>> On 3/13/13 7:58 AM, Carlos Maiolino wrote:
>>> Ah, my origin was pointing to the git.kernel.org xfsdump repository =[
>>
>> hch, can we please do something to those repos to make them more obviously
>> deprecated?
>
> Sorry, I totally forgot about that. I'll take care of it as soon as I
> get close to the kernel.org PGP key again which I usually keep in a
> physically safe place. Alternatively any other member of the xfs
> group on kernel.org could take care of it.
hch, I can do "it," but what exactly did you have in mind?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfsdump: properly set Parent's PID
2013-03-18 14:12 ` Eric Sandeen
@ 2013-03-18 17:13 ` Christoph Hellwig
0 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2013-03-18 17:13 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, Rich Johnston, Carlos Maiolino, xfs
On Mon, Mar 18, 2013 at 09:12:54AM -0500, Eric Sandeen wrote:
> hch, I can do "it," but what exactly did you have in mind?
My plans was to simply add a commit that removes all files and adds a
new MOVED file explaining the new location, and maybe a little blurb
on when and why it moved.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-03-18 17:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 20:13 [PATCH] xfsdump: properly set Parent's PID Carlos Maiolino
2013-03-12 16:34 ` Rich Johnston
2013-03-13 4:09 ` Eric Sandeen
2013-03-13 12:46 ` Carlos Maiolino
2013-03-13 12:58 ` Carlos Maiolino
2013-03-13 13:39 ` Eric Sandeen
2013-03-18 13:21 ` Christoph Hellwig
2013-03-18 14:12 ` Eric Sandeen
2013-03-18 17:13 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox