From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 05C3C7F37 for ; Wed, 13 Mar 2013 08:39:49 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id BBB0D8F8049 for ; Wed, 13 Mar 2013 06:39:48 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id PlzWCtjcn2fEdC6G for ; Wed, 13 Mar 2013 06:39:47 -0700 (PDT) Message-ID: <514081A2.9080106@sandeen.net> Date: Wed, 13 Mar 2013 08:39:46 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] xfsdump: properly set Parent's PID References: <1359663197-30473-1-git-send-email-cmaiolino@redhat.com> <513F58FE.1010200@sgi.com> <513FFC0D.3030705@sandeen.net> <20130313124651.GA2816@andromeda.usersys.redhat.com> <20130313125856.GB2816@andromeda.usersys.redhat.com> In-Reply-To: <20130313125856.GB2816@andromeda.usersys.redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Carlos Maiolino Cc: Christoph Hellwig , Rich Johnston , xfs@oss.sgi.com On 3/13/13 7:58 AM, Carlos Maiolino wrote: > Ah, my origin was pointing to the git.kernel.org xfsdump repository =[ hch, can we please do something to those repos to make them more obviously deprecated? Thanks, -Eric > On Wed, Mar 13, 2013 at 09:46:52AM -0300, Carlos Maiolino wrote: >> Weird, I git pull'ed the repository before add the patch, I'll review my >> origin's URL, sorry about that >> >> On Tue, Mar 12, 2013 at 11:09:49PM -0500, Eric Sandeen wrote: >>> On 3/12/13 11:34 AM, Rich Johnston wrote: >>>> On 01/31/2013 02:13 PM, Carlos Maiolino wrote: >>>>> Set parentpid variable to the correct Parent's ID using getppid() instead of >>>>> getpid() >>>>> >>>>> Signed-off-by: Carlos Maiolino >>>>> --- >>>>> common/main.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/common/main.c b/common/main.c >>>>> index 980d2d4..848a887 100644 >>>>> --- a/common/main.c >>>>> +++ b/common/main.c >>>>> @@ -198,7 +198,7 @@ main( int argc, char *argv[] ) >>>>> /* Get the parent's pid. will be used in signal handling >>>>> * to differentiate parent from children. >>>>> */ >>>>> - parentpid = getpid( ); >>>>> + parentpid = getppid( ); >>>>> rval = atexit(mlog_exit_flush); >>>>> assert(rval == 0); >>>>> >>>>> >>>> Sorry for the late review, this does not apply to current xfsdump tree. >>> >>> Hm, and hasn't since 2011. ;) >>> >>> 2da84e5d changed this: >>> >>> * to differentiate parent from children. >>> */ >>> - parentpid = getpid( ); >>> + parenttid = pthread_self( ); >>> >>> Carlos, was this maybe against an older tree or released version? >>> >>> -Eric >>> >>>> Regards >>>> --Rich >>> >>> _______________________________________________ >>> xfs mailing list >>> xfs@oss.sgi.com >>> http://oss.sgi.com/mailman/listinfo/xfs >> >> -- >> Carlos >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs