From: Eric Sandeen <sandeen@sandeen.net>
To: Philip White <pwhite@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 14/18] xfstests: remove -x functionality
Date: Fri, 15 Mar 2013 09:13:46 -0500 [thread overview]
Message-ID: <51432C9A.2010407@sandeen.net> (raw)
In-Reply-To: <20130314130611.A163253DEAFB@polaris-admin.engr.sgi.com>
On 3/14/13 8:06 AM, Philip White wrote:
> From: Phil White <pwhite@sgi.com>
>
>
> This is a rebasing & resubmit of a dchinner patch. His comments on the
> original:
> -----------------
> Now that there are no tests in the top level directory, the exlude
> group functionality no longer works (-x group) as it cannot find
> tests to build an initial list of tests. Rework the the exclude
> group implementation to operate correctly on the new test locations.
>
> Also, swtich from sed to grep for exclusion because sed has problems
> distnguishing the '/' in path names from regex control...
> -----------------
> This one is mildly different from the original as it modifies infrastructure
> which remains in common. In Dave's original patch, that had all been moved
> into check.
And the rationale for the change from the original is what? Changelogs are better with reasoning, than with just descriptions of change.
Just a style note - it's not great form to take someone else's large body of work, tweak it, then claim authorship (From:) and sign-off (Signed-off-by:). If it were me, I might be a little tweaked. It's probably an oversight, and maybe Dave doesn't even care, but it's my pet peeve.
Since Dave has rebased & resent the original patchset he wrote, it might be better, going forward, for you guys to try to reach agreement on any necessary changes to his body of work, and get that committed. Unless we want to carry on w/ dueling patchsets, which doesn't sound optimal to me.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-15 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:06 [PATCH 14/18] xfstests: remove -x functionality Philip White
2013-03-15 8:47 ` Dave Chinner
2013-03-15 14:13 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51432C9A.2010407@sandeen.net \
--to=sandeen@sandeen.net \
--cc=pwhite@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox