[PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

[PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

[Wang Sheng-Hui]

_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
  276 |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/276 b/276
index 40b30cf..87363ca 100755
--- a/276
+++ b/276
@@ -58,8 +58,7 @@ _need_to_be_root
  _supported_fs btrfs
  _supported_os Linux
  _require_scratch
-
-_require_nobigloopfs
+_require_no_large_scratch_dev
  _require_btrfs inspect-internal
  _require_command "/usr/sbin/filefrag"

-- 
1.7.10.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

[Wang Sheng-Hui]

On 2013年03月21日 14:13, Wang Sheng-Hui wrote:
> _require_nobigloopfs has been removed.
> We should use _require_no_large_scratch_dev in the test script.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>   276 |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/276 b/276
> index 40b30cf..87363ca 100755
> --- a/276
> +++ b/276
> @@ -58,8 +58,7 @@ _need_to_be_root
>   _supported_fs btrfs
>   _supported_os Linux
>   _require_scratch
> -
> -_require_nobigloopfs
> +_require_no_large_scratch_dev
>   _require_btrfs inspect-internal
>   _require_command "/usr/sbin/filefrag"
>

Does anyone notice this?
I use the upstream xfstests and failed this case for the already-removed function.
I think someone patched in but mixed the old function.
I've send out this patch for days, but seems no one cares about it.

If I'm wrong, please let me know.

Thanks,


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

[Jan Schmidt]

On Mon, March 25, 2013 at 05:35 (+0100), Wang Sheng-Hui wrote:
> On 2013年03月21日 14:13, Wang Sheng-Hui wrote:
>> _require_nobigloopfs has been removed.
>> We should use _require_no_large_scratch_dev in the test script.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>> ---
>>   276 |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/276 b/276
>> index 40b30cf..87363ca 100755
>> --- a/276
>> +++ b/276
>> @@ -58,8 +58,7 @@ _need_to_be_root
>>   _supported_fs btrfs
>>   _supported_os Linux
>>   _require_scratch
>> -
>> -_require_nobigloopfs
>> +_require_no_large_scratch_dev
>>   _require_btrfs inspect-internal
>>   _require_command "/usr/sbin/filefrag"
>>
> 
> Does anyone notice this?
> I use the upstream xfstests and failed this case for the already-removed function.
> I think someone patched in but mixed the old function.
> I've send out this patch for days, but seems no one cares about it.

Noticed it, too. I'd just delete that line instead - the test doesn't depend on
scratch dev size.

Thanks,
-Jan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

[Rich Johnston]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On 03/21/2013 01:13 AM, Wang Sheng-Hui wrote:
> _require_nobigloopfs has been removed.
> We should use _require_no_large_scratch_dev in the test script.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>   276 |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/276 b/276
> index 40b30cf..87363ca 100755
> --- a/276
> +++ b/276
> @@ -58,8 +58,7 @@ _need_to_be_root
>   _supported_fs btrfs
>   _supported_os Linux
>   _require_scratch
> -
> -_require_nobigloopfs
> +_require_no_large_scratch_dev
>   _require_btrfs inspect-internal
>   _require_command "/usr/sbin/filefrag"
>

Thanks for the patch.

Not sure what is wrong with your patch (trailing space maybe),
but it could not be imported using git quiltimport.

The patch itself makes sense so I have committed the attached:

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

commit 07c1f8d7bae36f2c28ffee6f09c318b1142b6f90
Author: Wang Sheng-Hui <shhuiw@gmail.com>
Date:   Thu Mar 21 06:13:23 2013 +0000

     xfstests 276: use _require_no_large_scratch_dev instead of the 
removed _require_nobigloopfs

[-- Attachment #2: p276.patch --]
[-- Type: text/x-patch, Size: 1117 bytes --]

>From patchwork Thu Mar 21 06:13:23 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: xfstests 276: use _require_no_large_scratch_dev instead of the
 removed _require_nobigloopfs
Date: Thu, 21 Mar 2013 06:13:23 -0000
From: Wang Sheng-Hui <shhuiw@gmail.com>
X-Patchwork-Id: 5083
Message-Id: <514AA503.4060101@gmail.com>
To: Dave Chinner <david@fromorbit.com>, xfstests <xfs@oss.sgi.com>,
 linux-btrfs@vger.kernel.org

_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>

---
 276 |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: b/276
===================================================================
--- a/276
+++ b/276
@@ -58,8 +58,7 @@ _need_to_be_root
 _supported_fs btrfs
 _supported_os Linux
 _require_scratch
-
-_require_nobigloopfs
+_require_no_large_scratch_dev
 _require_btrfs inspect-internal
 _require_command "/usr/sbin/filefrag"
 

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs