From: Jan Schmidt <list.xfs@jan-o-sch.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
Date: Mon, 25 Mar 2013 10:19:45 +0100 [thread overview]
Message-ID: <515016B1.4090607@jan-o-sch.net> (raw)
In-Reply-To: <514FD3FA.701@gmail.com>
On Mon, March 25, 2013 at 05:35 (+0100), Wang Sheng-Hui wrote:
> On 2013年03月21日 14:13, Wang Sheng-Hui wrote:
>> _require_nobigloopfs has been removed.
>> We should use _require_no_large_scratch_dev in the test script.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>> ---
>> 276 | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/276 b/276
>> index 40b30cf..87363ca 100755
>> --- a/276
>> +++ b/276
>> @@ -58,8 +58,7 @@ _need_to_be_root
>> _supported_fs btrfs
>> _supported_os Linux
>> _require_scratch
>> -
>> -_require_nobigloopfs
>> +_require_no_large_scratch_dev
>> _require_btrfs inspect-internal
>> _require_command "/usr/sbin/filefrag"
>>
>
> Does anyone notice this?
> I use the upstream xfstests and failed this case for the already-removed function.
> I think someone patched in but mixed the old function.
> I've send out this patch for days, but seems no one cares about it.
Noticed it, too. I'd just delete that line instead - the test doesn't depend on
scratch dev size.
Thanks,
-Jan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-25 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 6:13 [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs Wang Sheng-Hui
2013-03-25 4:35 ` Wang Sheng-Hui
2013-03-25 9:19 ` Jan Schmidt [this message]
2013-03-25 13:43 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515016B1.4090607@jan-o-sch.net \
--to=list.xfs@jan-o-sch.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox