* [PATCH] xfstests: check: set up config variables before using them
@ 2013-03-28 17:00 David Sterba
2013-03-28 20:57 ` Rich Johnston
2013-03-28 21:07 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: David Sterba @ 2013-03-28 17:00 UTC (permalink / raw)
To: xfs; +Cc: David Sterba
HOSTOS was used in a test before being initialized and this led to
failed filesystem type detection.
Signed-off-by: David Sterba <dsterba@suse.cz>
---
Sidenote, FSTYP has been exported properly, I've accidentally deleted it during
debugging. The patch "xfstests: remove unconditional setting of FSTYP" is now
obsolete.
check | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/check b/check
index 18cae75..3b48402 100755
--- a/check
+++ b/check
@@ -50,12 +50,6 @@ timestamp=${TIMESTAMP:=false}
rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist
-# Autodetect fs type based on what's on $TEST_DEV
-if [ "$HOSTOS" == "Linux" ]; then
- FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV`
-fi
-export FSTYP
-
# we need common.config
if ! . ./common/config
then
@@ -63,6 +57,12 @@ then
exit 1
fi
+# Autodetect fs type based on what's on $TEST_DEV
+if [ "$HOSTOS" == "Linux" ]; then
+ FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV`
+fi
+export FSTYP
+
SUPPORTED_TESTS="[0-9][0-9][0-9] [0-9][0-9][0-9][0-9]"
SRC_GROUPS="generic shared"
export SRC_DIR="tests"
--
1.8.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-28 21:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28 17:00 [PATCH] xfstests: check: set up config variables before using them David Sterba
2013-03-28 20:57 ` Rich Johnston
2013-03-28 21:07 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox