From: Rich Johnston <rjohnston@sgi.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix common rc file path in new
Date: Thu, 28 Mar 2013 22:18:01 -0500 [thread overview]
Message-ID: <515507E9.4010009@sgi.com> (raw)
In-Reply-To: <51546B33.6090608@sgi.com>
On 03/28/2013 11:09 AM, Rich Johnston wrote:
>
> You caught the first one but I think you should also change the template
> entries too:
>
> 123 # get standard environment, filters and checks
> 124 . ./common/rc
> 125 . ./common/filter
>
> Other than that looks good.
>
> --Rich
>
>
I also noticed that there are several echo statements in the common
directory that should be cleaned up with:
cd xfstests/common/
for f in `ls`; do sed -i -e's/common\./common\//g' $f; done
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-29 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:51 [PATCH] xfstests: fix common rc file path in new Eryu Guan
2013-03-28 16:09 ` Rich Johnston
2013-03-29 3:18 ` Rich Johnston [this message]
2013-03-29 0:38 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515507E9.4010009@sgi.com \
--to=rjohnston@sgi.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox