* [PATCH] xfstests: set correct seqres variable in new when creating test template
@ 2013-04-01 10:58 Eryu Guan
2013-04-01 13:19 ` Rich Johnston
2013-04-01 13:22 ` Rich Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Eryu Guan @ 2013-04-01 10:58 UTC (permalink / raw)
To: xfs; +Cc: Eryu Guan
When setting seqres in the new script, '$' should be escaped,
otherwise seqres will be set to '/' not '$RESULT_DIR/$seq'
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
new | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/new b/new
index d9c38c8..2bc1e8f 100755
--- a/new
+++ b/new
@@ -106,7 +106,7 @@ cat <<End-of-File >$id
#
# creator
seq=\`basename \$0\`
-seqres=$RESULT_DIR/$seq
+seqres=\$RESULT_DIR/\$seq
echo "QA output created by \$seq"
here=\`pwd\`
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: set correct seqres variable in new when creating test template
2013-04-01 10:58 [PATCH] xfstests: set correct seqres variable in new when creating test template Eryu Guan
@ 2013-04-01 13:19 ` Rich Johnston
2013-04-01 13:22 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-04-01 13:19 UTC (permalink / raw)
To: Eryu Guan; +Cc: xfs
Looks good.
--Rich
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: set correct seqres variable in new when creating test template
2013-04-01 10:58 [PATCH] xfstests: set correct seqres variable in new when creating test template Eryu Guan
2013-04-01 13:19 ` Rich Johnston
@ 2013-04-01 13:22 ` Rich Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-04-01 13:22 UTC (permalink / raw)
To: Eryu Guan; +Cc: xfs
Eryu,
Thanks for submitting this patch, it has been committed.
--Rich
commit d1ec02af9e0516652ce92584dc4f92704579af18
Author: Eryu Guan <eguan@redhat.com>
Date: Mon Apr 1 10:58:15 2013 +0000
xfstests: set correct seqres variable in new when creating test
template
When setting seqres in the new script, '$' should be escaped,
otherwise seqres will be set to '/' not '$RESULT_DIR/$seq'
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-01 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 10:58 [PATCH] xfstests: set correct seqres variable in new when creating test template Eryu Guan
2013-04-01 13:19 ` Rich Johnston
2013-04-01 13:22 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox