Re: [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle

Ben Myers
2013-05-08T00:01:44Z

On Thu, Apr 25, 2013 at 11:13:06AM -0500, Eric Sandeen wrote:
> Shamelessly copied from dchinner's:
> ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
>
> xfsdump uses a large buffer for extended attributes, which has a
> kmalloc'd shadow buffer in the kernel. This can fail after the
> system has been running for some time as it is a high order
> allocation. Add a fallback to vmalloc so that it doesn't require
> contiguous memory and so won't randomly fail while xfsdump is
> running.
>
> This was done for xfs_attrlist_by_handle but
> xfs_compat_attrlist_by_handle (the 32-bit version) needs the same
> attention.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Applied.