From: Mark Tinguely <tinguely@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Update xfs_log_commit_cil() comments
Date: Mon, 08 Apr 2013 15:59:20 -0500 [thread overview]
Message-ID: <51632FA8.8020703@sgi.com> (raw)
In-Reply-To: <515D34B2.9050807@oracle.com>
On 04/04/13 03:07, Jeff Liu wrote:
> xfs_log_commit_iclog() function has been removed by commits 93b8a585:
> xfs: remove the deprecated nodelaylog option
>
> Beginning from Linux 3.3, only delayed logging is supported so that
> we call xfs_log_commit_cil() at xfs_trans_commit() only, remove the
> useless comments so.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> ---
> fs/xfs/xfs_log_cil.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
> index ddc4529..e3d0b85 100644
> --- a/fs/xfs/xfs_log_cil.c
> +++ b/fs/xfs/xfs_log_cil.c
> @@ -668,10 +668,6 @@ xlog_cil_push_foreground(
> * transaction to the checkpoint context so we carry the busy extents through
> * to checkpoint completion, and then unlock all the items in the transaction.
> *
> - * For more specific information about the order of operations in
> - * xfs_log_commit_cil() please refer to the comments in
> - * xfs_trans_commit_iclog().
> - *
> * Called with the context lock already held in read mode to lock out
> * background commit, returns without it held once background commits are
> * allowed again.
And the log is documented in
Documents/filesystems/xfs-delayed-logging-design.txt.
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-04-08 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 8:07 [PATCH] xfs: Update xfs_log_commit_cil() comments Jeff Liu
2013-04-08 20:59 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51632FA8.8020703@sgi.com \
--to=tinguely@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox