From: Mark Tinguely <tinguely@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros
Date: Mon, 08 Apr 2013 16:30:54 -0500 [thread overview]
Message-ID: <5163370E.6090804@sgi.com> (raw)
In-Reply-To: <515CFD42.70109@oracle.com>
On 04/03/13 23:10, Jeff Liu wrote:
> There is no more users of this Macro, so it's time to kill it dead.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> ---
> fs/xfs/xfs_log_priv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 16d8d12..b9ea262 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -468,7 +468,6 @@ struct xfs_cil {
> * threshold, yet give us plenty of space for aggregation on large logs.
> */
> #define XLOG_CIL_SPACE_LIMIT(log) (log->l_logsize>> 3)
> -#define XLOG_CIL_HARD_SPACE_LIMIT(log) (3 * (log->l_logsize>> 4))
>
> /*
> * ticket grant locks, queues and accounting have their own cachlines
Removed in commit:
commit 4c2d542f2e786537db33b613d5199dc6d69a96da
Author: Dave Chinner <david@fromorbit.com>
Date: Mon Apr 23 17:54:32 2012 +1000
xfs: Do background CIL flushes via a workqueue
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-04-08 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 4:10 [PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros Jeff Liu
2013-04-08 21:30 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163370E.6090804@sgi.com \
--to=tinguely@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox