[PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

[PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

[Jeff Liu]

There is no more users of this Macro, so it's time to kill it dead.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 fs/xfs/xfs_log_priv.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index 16d8d12..b9ea262 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -468,7 +468,6 @@ struct xfs_cil {
  * threshold, yet give us plenty of space for aggregation on large logs.
  */
 #define XLOG_CIL_SPACE_LIMIT(log)	(log->l_logsize >> 3)
-#define XLOG_CIL_HARD_SPACE_LIMIT(log)	(3 * (log->l_logsize >> 4))

 /*
  * ticket grant locks, queues and accounting have their own cachlines
-- 
1.7.9.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

[Mark Tinguely]

On 04/03/13 23:10, Jeff Liu wrote:
> There is no more users of this Macro, so it's time to kill it dead.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> ---
>   fs/xfs/xfs_log_priv.h |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 16d8d12..b9ea262 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -468,7 +468,6 @@ struct xfs_cil {
>    * threshold, yet give us plenty of space for aggregation on large logs.
>    */
>   #define XLOG_CIL_SPACE_LIMIT(log)	(log->l_logsize>>  3)
> -#define XLOG_CIL_HARD_SPACE_LIMIT(log)	(3 * (log->l_logsize>>  4))
>
>   /*
>    * ticket grant locks, queues and accounting have their own cachlines

Removed in commit:

commit 4c2d542f2e786537db33b613d5199dc6d69a96da
Author: Dave Chinner <david@fromorbit.com>
Date:   Mon Apr 23 17:54:32 2012 +1000

     xfs: Do background CIL flushes via a workqueue

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs