public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael L. Semon" <mlsemon35@gmail.com>
To: xfstests <xfs@oss.sgi.com>
Subject: xfstests: kludge patch for per-dir test number sorting by ./check
Date: Sat, 13 Apr 2013 16:50:06 -0400	[thread overview]
Message-ID: <5169C4FE.4030209@gmail.com> (raw)

I'm trying to get the new xfstests to run the XFS tests first, then run 
the generic group, then run the shared group.  One attempt was to work 
with this variable in the ./check script:

SRC_GROUPS="generic shared"

There is a final file sort in ./check that means, no matter which order 
groups are specified in SRC_GROUPS, the groups will be executed in 
alphabetical order.  This sysadmin kludge patch fixes that behavior and 
seems to work.  By moving the sorting into the trim_test_list() 
function, test numbers are still sorted, but the groups seem to run in 
the order specified in the SRC_GROUPS variable.

Let me know if this helps or if I'm simply not using the new xfstests 
correctly.

Michael

--- xfstests/check.orig	2013-03-30 00:54:37.000000000 -0400
+++ xfstests/check	2013-04-13 13:41:42.002814733 -0400
@@ -138,7 +138,7 @@
  	    echo "^$t\$" >>$tmp.grep
  	    numsed=`expr $numsed + 1`
  	done
-	grep -v -f $tmp.grep <$tmp.list >$tmp.tmp
+	grep -v -f $tmp.grep <$tmp.list | sort -n >$tmp.tmp
  	mv $tmp.tmp $tmp.list
  }

@@ -268,7 +268,7 @@
  fi

  # sort the list of tests into numeric order
-list=`sort -n $tmp.list`
+list=`cat $tmp.list`
  rm -f $tmp.list $tmp.tmp $tmp.grep

  if $randomize

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-04-13 20:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 20:50 Michael L. Semon [this message]
2013-04-14 23:26 ` xfstests: kludge patch for per-dir test number sorting by ./check Dave Chinner
2013-04-15  3:29   ` Michael L. Semon
2013-04-22 18:25     ` Rich Johnston
2013-04-23 14:08       ` Michael L. Semon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5169C4FE.4030209@gmail.com \
    --to=mlsemon35@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox