From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfstests <xfs@oss.sgi.com>, Dave Chinner <dchinner@redhat.com>,
Wang Sheng-Hui <shhuiw@gmail.com>
Subject: Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs
Date: Mon, 15 Apr 2013 07:42:15 -0500 [thread overview]
Message-ID: <516BF5A7.4050100@sgi.com> (raw)
In-Reply-To: <20130413003829.GH30622@dastard>
On 04/12/2013 07:38 PM, Dave Chinner wrote:
> On Fri, Apr 12, 2013 at 01:41:22PM -0500, Rich Johnston wrote:
>> On 04/12/2013 11:42 AM, Wang Sheng-Hui wrote:
>>>
>>> Hi Dave,
>>>
>>> I introduces Makefile under tests/, which would return to TESTS_SUBDIRS
>>> with the
>>> $(dir function. By running find in $(shell, TEST_SUBDIRS will only get
>>> the dir names,
>>> and no Makefile.
>>>
>>> Regards,
>>> Sheng-Hui
>>
>> Thanks addressing comments and for v2 of this patch.
>>
>> I still had issues with Makefile which I corrected at commit time.
>>
>> Thanks again for the patch, it has been committed,
>
> Rich, it's great that you are picking this stuff up quickly, but as
> I asked recently, please don't commit patches while there is still
> an active review conversation going on....
>
> Cheers,
>
> Dave.
>
Dave,
I was a little quick on the draw, I will wait till all parties have
concluded discussions.
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-04-15 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 4:26 [PATCH v2] xfstests: make install support common/ and tests/ dirs Wang Sheng-Hui
2013-04-12 7:40 ` Dave Chinner
2013-04-12 16:42 ` Wang Sheng-Hui
2013-04-12 18:41 ` Rich Johnston
2013-04-13 0:38 ` Dave Chinner
2013-04-15 12:42 ` Rich Johnston [this message]
2013-04-15 12:45 ` Rich Johnston
2013-04-13 0:32 ` Dave Chinner
2013-04-13 10:18 ` Wang Sheng-Hui
2013-04-13 10:37 ` Wang Sheng-Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BF5A7.4050100@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=shhuiw@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox