Re: [PATCH 3/3 V2] xfsprogs: Fix up usage() errors and omissions

Rich Johnston
2013-04-25T16:13:14Z

On 04/25/2013 10:16 AM, Eric Sandeen wrote:
> Add missing options and remove invalid options in usage() output
> strings.
>
> * Add -V to several usage() strings
> * Remove deprecated/invalid -n and -s otions from xfs_fsr's usage
> * Remove invalid -I option from xfs_growfs's usage
> * Add -n (O_NONBLOCK) option to xfs_io's usage
> * Add -e (exit on error) option to xfs_logprint's usage
> * Remove invalid -b option from xfs_mdrestore's usage
> * Add -N (no-op), -K (no discard), and -f (force) to mkfs.xfs's usage
> * Add -x (expert) option to xfs_quota's usage
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: address Rich's nitpicky review ;) (i.e. fix good stuff)

Thanks again for V2. Looks good.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>