public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/3 V2] xfsprogs: Fix up usage() errors and omissions
Date: Thu, 25 Apr 2013 11:13:29 -0500	[thread overview]
Message-ID: <51795629.1000708@sgi.com> (raw)
In-Reply-To: <517948D2.7070706@sandeen.net>

On 04/25/2013 10:16 AM, Eric Sandeen wrote:
> Add missing options and remove invalid options in usage() output
> strings.
>
> * Add -V to several usage() strings
> * Remove deprecated/invalid -n and -s otions from xfs_fsr's usage
> * Remove invalid -I option from xfs_growfs's usage
> * Add -n (O_NONBLOCK) option to xfs_io's usage
> * Add -e (exit on error) option to xfs_logprint's usage
> * Remove invalid -b option from xfs_mdrestore's usage
> * Add -N (no-op), -K (no discard), and -f (force) to mkfs.xfs's usage
> * Add -x (expert) option to xfs_quota's usage
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: address Rich's nitpicky review ;)  (i.e. fix good stuff)

Thanks again for V2.  Looks good.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-04-25 16:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 22:37 [PATCH 0/3] xfsprogs: manpage & usage string fixups Eric Sandeen
2013-04-22 22:39 ` [PATCH 1/3] xfsprogs: manpage spelling fixes Eric Sandeen
2013-04-23 15:18   ` Rich Johnston
2013-04-23 15:43     ` Dave Howorth
2013-04-23 15:59       ` Rich Johnston
2013-04-23 16:20         ` Stefan Ring
2013-04-23 19:36     ` Eric Sandeen
2013-04-25 14:12   ` [PATCH 1/3 V2] " Eric Sandeen
2013-04-25 14:59     ` Rich Johnston
2013-04-25 20:43     ` Rich Johnston
2013-04-22 22:40 ` [PATCH 2/3] xfsprogs: Fix manpages for missing or incorrect options Eric Sandeen
2013-04-23 18:35   ` Rich Johnston
2013-04-23 19:36     ` Eric Sandeen
2013-04-23 19:45       ` Rich Johnston
2013-04-25 15:03   ` [PATCH 2/3 V2] " Eric Sandeen
2013-04-25 15:26     ` Rich Johnston
2013-04-25 15:52     ` Rich Johnston
2013-04-22 22:42 ` [PATCH 3/3] xfsprogs: Fix up usage() errors and omissions Eric Sandeen
2013-04-23 19:37   ` Rich Johnston
2013-04-25 15:16   ` [PATCH 3/3 V2] " Eric Sandeen
2013-04-25 16:13     ` Rich Johnston [this message]
2013-04-25 16:15     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51795629.1000708@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox