From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests shared/298: various fixes
Date: Tue, 30 Apr 2013 09:17:49 -0500 [thread overview]
Message-ID: <517FD28D.3020402@sandeen.net> (raw)
In-Reply-To: <20130430074348.GK23072@dastard>
On 4/30/13 2:43 AM, Dave Chinner wrote:
> On Fri, Apr 26, 2013 at 03:18:52PM -0500, Eric Sandeen wrote:
>> fix shared/298:
>>
>> * don't include common/config, not needed and breaks
>> stuff when $SCRATCH_DEV_POOL is defined:
>> Error: $SCRATCH_DEV should be unset when $SCRATCH_DEV_POOL is set
>> * make sure xfs_io has fiemap, we'll need it
>> * add -F to the xfs_io invocation, again
>
> What's it needed for this time?
the same as last time. :) using old xfs_io on a non-xfs fs.
>> * ignore ENOSPC errors from "garbage" loop; the only goal
>> is to fill it, ENOSPC doesn't matter.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> Wondering if we should just add " -F" to $XFS_IO_PROG . . .
>>
>> diff --git a/tests/shared/298 b/tests/shared/298
>> index f1a3432..e2eddda 100755
>> --- a/tests/shared/298
>> +++ b/tests/shared/298
>> @@ -28,12 +28,12 @@ echo "QA output created by $seq"
>> status=1 # failure is the default!
>> trap "_cleanup; exit \$status" 0 1 2 3 15
>>
>> -. common/config
>> . common/rc
>>
>> _supported_fs ext4 xfs
>> _supported_os Linux
>> _require_fstrim
>> +_require_xfs_io_fiemap
>> _require_fs_space $TEST_DIR 307200
>> [ "$FSTYP" = "ext4" ] && _require_dumpe2fs
>>
>> @@ -49,7 +49,7 @@ _cleanup()
>>
>> get_holes()
>> {
>> - $XFS_IO_PROG -c fiemap $1 | grep hole | $SED_PROG 's/.*\[\(.*\)\.\.\(.*\)\].*/\1 \2/'
>> + $XFS_IO_PROG -F -c fiemap $1 | grep hole | $SED_PROG 's/.*\[\(.*\)\.\.\(.*\)\].*/\1 \2/'
>> }
>>
>> get_free_sectors()
>> @@ -136,9 +136,10 @@ $MKFS_PROG -t $FSTYP $MKFS_OPTIONS $loop_dev &> /dev/null
>> $MOUNT_PROG $loop_dev $loop_mnt
>>
>> echo -n "Generating garbage on loop..."
>> +# Goal is to fill it up, ignore any errors.
>> for i in `seq 1 10`; do
>> - mkdir $loop_mnt/$i
>> - cp -r $here/* $loop_mnt/$i
>> + mkdir $loop_mnt/$i &> /dev/null
>> + cp -r $here/* $loop_mnt/$i &> /dev/null
>
> Can you break out of the loop once cp fails with an error? There's
> no point hammering the filesystem for several loops after the first
> ENOSPC occurs....
yeah, ok.
Thanks,
-Eric
> -Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-04-30 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 20:18 [PATCH] xfstests shared/298: various fixes Eric Sandeen
2013-04-30 7:43 ` Dave Chinner
2013-04-30 14:17 ` Eric Sandeen [this message]
2013-04-30 16:46 ` [PATCH V2] " Eric Sandeen
2013-05-03 13:00 ` Rich Johnston
2013-05-14 18:15 ` Rich Johnston
2013-05-14 18:18 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FD28D.3020402@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox