xfsprogs-3.1.11 pre-release please test!

xfsprogs-3.1.11 pre-release please test!

[Rich Johnston]

Hi Folks,

Here are the changes for this release:

xfsprogs-3.1.11 (30 April 2013)

         - Support for relative paths in xfs_quota thanks to Satoru 
Takeuchi.
         - mkfs.xfs will always go into multidisk mode when filesystem
           geometry is specified on the command line.
         - Document all commands in xfs_io.
         - Remove setfl command from xfs_io.
         - xfs_metadump will obfuscate symlinks by path component.
         - mkfs.xfs no longer accepts geometry settings smaller than the
           physical sector size.
         - xfs_logprint now supports multiply-logged inode fields and
           handles continued inode transactions correctly.
         - kill XLOG_SET
         - Update release scripts to use git archive to address a
           missing source file reported by Arkadiusz Mi?kiewicz
         - Fix a build error with -Werror=format-security, reported
           by Arkadiusz Mi?kiewicz
         - mkfs.xfs no longer attempts to discard when -N option is used.
         - Update 'make deb' to use tarball
         - Sync up with log reservation changes in the kernel.
         - Fix possible unallocated memory access in fiemap.
         - Guard against string overflow in path_to_fspath.
         - Fix setup_cursor array allocation.
         - Fix free of unintialized pointer in xfs_acl_valid error path.
         - Guard against path string overflows.
         - Check strdup results properly in initallfs().
         - Fix attribute no_change_count logic.
         - Remove extraneous close() in fsrallfs().
         - xfs_repair now skips the freelist scan of a corrupt agf
           when in no-modify mode.
         - xfs_db now skips freelist scans of corrupt agfs.
         - Remove unconditional ASSERT(0) in xfs_repair.
         - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf 
space.
         - Add depraction message for xfs_check.
         - xfs_quota allow user or group names beginning with digits 
reported by
           James Carter.
         - Fix manpages and usage() spelling, errors and omissions.

I have placed a pre-release tarball here:

ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz

Please take a look and report any issues before next Wednesday (08 May 
2013).  If there are other patches which you feel are essential, now is 
the time to say so.

Regards
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

xfsprogs-3.1.11 pre-release please test!

[Rich Johnston]

Hi Folks,

Here are the changes for this release:

xfsprogs-3.1.11 (30 April 2013)

         - Support for relative paths in xfs_quota thanks to Satoru 
Takeuchi.
         - mkfs.xfs will always go into multidisk mode when filesystem
           geometry is specified on the command line.
         - Document all commands in xfs_io.
         - Remove setfl command from xfs_io.
         - xfs_metadump will obfuscate symlinks by path component.
         - mkfs.xfs no longer accepts geometry settings smaller than the
           physical sector size.
         - xfs_logprint now supports multiply-logged inode fields and
           handles continued inode transactions correctly.
         - kill XLOG_SET
         - Update release scripts to use git archive to address a
           missing source file reported by Arkadiusz Mi?kiewicz
         - Fix a build error with -Werror=format-security, reported
           by Arkadiusz Mi?kiewicz
         - mkfs.xfs no longer attempts to discard when -N option is used.
         - Update 'make deb' to use tarball
         - Sync up with log reservation changes in the kernel.
         - Fix possible unallocated memory access in fiemap.
         - Guard against string overflow in path_to_fspath.
         - Fix setup_cursor array allocation.
         - Fix free of unintialized pointer in xfs_acl_valid error path.
         - Guard against path string overflows.
         - Check strdup results properly in initallfs().
         - Fix attribute no_change_count logic.
         - Remove extraneous close() in fsrallfs().
         - xfs_repair now skips the freelist scan of a corrupt agf
           when in no-modify mode.
         - xfs_db now skips freelist scans of corrupt agfs.
         - Remove unconditional ASSERT(0) in xfs_repair.
         - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf 
space.
         - Add depraction message for xfs_check.
         - xfs_quota allow user or group names beginning with digits 
reported by
           James Carter.
         - Fix manpages and usage() spelling, errors and omissions.

I have placed a pre-release tarball here:

ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz

Please take a look and report any issues before next Wednesday (08 May 
2013).  If there are other patches which you feel are essential, now is 
the time to say so.

Regards
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Mark Tinguely]

On 05/01/13 15:12, Rich Johnston wrote:
> Hi Folks,
>
> Here are the changes for this release:
>
> xfsprogs-3.1.11 (30 April 2013)
>
> - Support for relative paths in xfs_quota thanks to Satoru Takeuchi.
> - mkfs.xfs will always go into multidisk mode when filesystem
> geometry is specified on the command line.
> - Document all commands in xfs_io.
> - Remove setfl command from xfs_io.
> - xfs_metadump will obfuscate symlinks by path component.
> - mkfs.xfs no longer accepts geometry settings smaller than the
> physical sector size.
> - xfs_logprint now supports multiply-logged inode fields and
> handles continued inode transactions correctly.
> - kill XLOG_SET
> - Update release scripts to use git archive to address a
> missing source file reported by Arkadiusz Mi?kiewicz
> - Fix a build error with -Werror=format-security, reported
> by Arkadiusz Mi?kiewicz
> - mkfs.xfs no longer attempts to discard when -N option is used.
> - Update 'make deb' to use tarball
> - Sync up with log reservation changes in the kernel.
> - Fix possible unallocated memory access in fiemap.
> - Guard against string overflow in path_to_fspath.
> - Fix setup_cursor array allocation.
> - Fix free of unintialized pointer in xfs_acl_valid error path.
> - Guard against path string overflows.
> - Check strdup results properly in initallfs().
> - Fix attribute no_change_count logic.
> - Remove extraneous close() in fsrallfs().
> - xfs_repair now skips the freelist scan of a corrupt agf
> when in no-modify mode.
> - xfs_db now skips freelist scans of corrupt agfs.
> - Remove unconditional ASSERT(0) in xfs_repair.
> - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf space.
> - Add depraction message for xfs_check.
> - xfs_quota allow user or group names beginning with digits reported by
> James Carter.
> - Fix manpages and usage() spelling, errors and omissions.
>
> I have placed a pre-release tarball here:
>
> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>
>
> Please take a look and report any issues before next Wednesday (08 May
> 2013). If there are other patches which you feel are essential, now is
> the time to say so.
>
> Regards
> --Rich

The new lines (below) in xfs_check.sh breaks older xfstests:

   xfs_check is deprecated and scheduled for removal in June 2014.
   Please use xfs_repair -n <dev> instead.

xfstests' ./check thinks the TEST directory is inconsistent and stops.
I simply commented the lines out of the installed /usr/sbin/xfs_check
for my tests.

FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 host 3.9.0-rc1+
MKFS_OPTIONS  -- -f -bsize=4096 {SCRATCH_DEV}
MOUNT_OPTIONS -- {SCRATCH_DEV} {SCRATCH_MNT}

_check_xfs_filesystem: filesystem on {TEST_DEV} is inconsistent (c) (see 
check.full)
Passed all 0 tests

--Mark.



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Eric Sandeen]

On 5/1/13 3:35 PM, Mark Tinguely wrote:
> On 05/01/13 15:12, Rich Johnston wrote:
>> Hi Folks,
>>
>> Here are the changes for this release:
>>
>> xfsprogs-3.1.11 (30 April 2013)
>>
>> - Support for relative paths in xfs_quota thanks to Satoru Takeuchi.
>> - mkfs.xfs will always go into multidisk mode when filesystem
>> geometry is specified on the command line.
>> - Document all commands in xfs_io.
>> - Remove setfl command from xfs_io.
>> - xfs_metadump will obfuscate symlinks by path component.
>> - mkfs.xfs no longer accepts geometry settings smaller than the
>> physical sector size.
>> - xfs_logprint now supports multiply-logged inode fields and
>> handles continued inode transactions correctly.
>> - kill XLOG_SET
>> - Update release scripts to use git archive to address a
>> missing source file reported by Arkadiusz Mi?kiewicz
>> - Fix a build error with -Werror=format-security, reported
>> by Arkadiusz Mi?kiewicz
>> - mkfs.xfs no longer attempts to discard when -N option is used.
>> - Update 'make deb' to use tarball
>> - Sync up with log reservation changes in the kernel.
>> - Fix possible unallocated memory access in fiemap.
>> - Guard against string overflow in path_to_fspath.
>> - Fix setup_cursor array allocation.
>> - Fix free of unintialized pointer in xfs_acl_valid error path.
>> - Guard against path string overflows.
>> - Check strdup results properly in initallfs().
>> - Fix attribute no_change_count logic.
>> - Remove extraneous close() in fsrallfs().
>> - xfs_repair now skips the freelist scan of a corrupt agf
>> when in no-modify mode.
>> - xfs_db now skips freelist scans of corrupt agfs.
>> - Remove unconditional ASSERT(0) in xfs_repair.
>> - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf space.
>> - Add depraction message for xfs_check.
>> - xfs_quota allow user or group names beginning with digits reported by
>> James Carter.
>> - Fix manpages and usage() spelling, errors and omissions.
>>
>> I have placed a pre-release tarball here:
>>
>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>>
>>
>> Please take a look and report any issues before next Wednesday (08 May
>> 2013). If there are other patches which you feel are essential, now is
>> the time to say so.
>>
>> Regards
>> --Rich
> 
> The new lines (below) in xfs_check.sh breaks older xfstests:
> 
>   xfs_check is deprecated and scheduled for removal in June 2014.
>   Please use xfs_repair -n <dev> instead.

Hum, I thought xfstests stopped calling xfs_check.sh and implemented
its own xfs_check internally:

commit 187bccd310dc253feaebd69df4ccdda21eee12d0
Author: Chandra Seetharaman <sekharan@us.ibm.com>
Date:   Thu Apr 18 17:44:02 2013 +0000

    xfstests: Remove dependence of xfs_check script
    
    Replace the usage of the script xfs_check and add the relevant code to
    xfstests.

...
-        [ "$XFS_CHECK_PROG" = "" ] && _fatal "xfs_check not found"
... etc ...

where is check getting called directly?

(Or: is your xfstests up to date?)

-Eric

> xfstests' ./check thinks the TEST directory is inconsistent and stops.
> I simply commented the lines out of the installed /usr/sbin/xfs_check
> for my tests.
> 
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 host 3.9.0-rc1+
> MKFS_OPTIONS  -- -f -bsize=4096 {SCRATCH_DEV}
> MOUNT_OPTIONS -- {SCRATCH_DEV} {SCRATCH_MNT}
> 
> _check_xfs_filesystem: filesystem on {TEST_DEV} is inconsistent (c) (see check.full)
> Passed all 0 tests
> 
> --Mark.
> 
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Mark Tinguely]

On 05/01/13 16:01, Eric Sandeen wrote:
> On 5/1/13 3:35 PM, Mark Tinguely wrote:
>> On 05/01/13 15:12, Rich Johnston wrote:
>>> Hi Folks,
>>>
>>> Here are the changes for this release:
>>>
>>> xfsprogs-3.1.11 (30 April 2013)
>>>
>>> - Support for relative paths in xfs_quota thanks to Satoru Takeuchi.
>>> - mkfs.xfs will always go into multidisk mode when filesystem
>>> geometry is specified on the command line.
>>> - Document all commands in xfs_io.
>>> - Remove setfl command from xfs_io.
>>> - xfs_metadump will obfuscate symlinks by path component.
>>> - mkfs.xfs no longer accepts geometry settings smaller than the
>>> physical sector size.
>>> - xfs_logprint now supports multiply-logged inode fields and
>>> handles continued inode transactions correctly.
>>> - kill XLOG_SET
>>> - Update release scripts to use git archive to address a
>>> missing source file reported by Arkadiusz Mi?kiewicz
>>> - Fix a build error with -Werror=format-security, reported
>>> by Arkadiusz Mi?kiewicz
>>> - mkfs.xfs no longer attempts to discard when -N option is used.
>>> - Update 'make deb' to use tarball
>>> - Sync up with log reservation changes in the kernel.
>>> - Fix possible unallocated memory access in fiemap.
>>> - Guard against string overflow in path_to_fspath.
>>> - Fix setup_cursor array allocation.
>>> - Fix free of unintialized pointer in xfs_acl_valid error path.
>>> - Guard against path string overflows.
>>> - Check strdup results properly in initallfs().
>>> - Fix attribute no_change_count logic.
>>> - Remove extraneous close() in fsrallfs().
>>> - xfs_repair now skips the freelist scan of a corrupt agf
>>> when in no-modify mode.
>>> - xfs_db now skips freelist scans of corrupt agfs.
>>> - Remove unconditional ASSERT(0) in xfs_repair.
>>> - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf space.
>>> - Add depraction message for xfs_check.
>>> - xfs_quota allow user or group names beginning with digits reported by
>>> James Carter.
>>> - Fix manpages and usage() spelling, errors and omissions.
>>>
>>> I have placed a pre-release tarball here:
>>>
>>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>>>
>>>
>>> Please take a look and report any issues before next Wednesday (08 May
>>> 2013). If there are other patches which you feel are essential, now is
>>> the time to say so.
>>>
>>> Regards
>>> --Rich
>>
>> The new lines (below) in xfs_check.sh breaks older xfstests:
>>
>>    xfs_check is deprecated and scheduled for removal in June 2014.
>>    Please use xfs_repair -n<dev>  instead.
>
> Hum, I thought xfstests stopped calling xfs_check.sh and implemented
> its own xfs_check internally:
>
> commit 187bccd310dc253feaebd69df4ccdda21eee12d0
> Author: Chandra Seetharaman<sekharan@us.ibm.com>
> Date:   Thu Apr 18 17:44:02 2013 +0000
>
>      xfstests: Remove dependence of xfs_check script
>
>      Replace the usage of the script xfs_check and add the relevant code to
>      xfstests.
>
> ...
> -        [ "$XFS_CHECK_PROG" = "" ]&&  _fatal "xfs_check not found"
> ... etc ...
>
> where is check getting called directly?
>
> (Or: is your xfstests up to date?)
>
> -Eric

I disclosed it as an older xfstests.

It is conceivable that people will install the latest xfsprogs and not 
upgrade xfstests. I can hear it now, "It used to just work..." :)

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Eric Sandeen]

On 5/1/13 4:17 PM, Mark Tinguely wrote:
> On 05/01/13 16:01, Eric Sandeen wrote:
>> On 5/1/13 3:35 PM, Mark Tinguely wrote:
>>> On 05/01/13 15:12, Rich Johnston wrote:
>>>> Hi Folks,
>>>>
>>>> Here are the changes for this release:
>>>>
>>>> xfsprogs-3.1.11 (30 April 2013)
>>>>
>>>> - Support for relative paths in xfs_quota thanks to Satoru Takeuchi.
>>>> - mkfs.xfs will always go into multidisk mode when filesystem
>>>> geometry is specified on the command line.
>>>> - Document all commands in xfs_io.
>>>> - Remove setfl command from xfs_io.
>>>> - xfs_metadump will obfuscate symlinks by path component.
>>>> - mkfs.xfs no longer accepts geometry settings smaller than the
>>>> physical sector size.
>>>> - xfs_logprint now supports multiply-logged inode fields and
>>>> handles continued inode transactions correctly.
>>>> - kill XLOG_SET
>>>> - Update release scripts to use git archive to address a
>>>> missing source file reported by Arkadiusz Mi?kiewicz
>>>> - Fix a build error with -Werror=format-security, reported
>>>> by Arkadiusz Mi?kiewicz
>>>> - mkfs.xfs no longer attempts to discard when -N option is used.
>>>> - Update 'make deb' to use tarball
>>>> - Sync up with log reservation changes in the kernel.
>>>> - Fix possible unallocated memory access in fiemap.
>>>> - Guard against string overflow in path_to_fspath.
>>>> - Fix setup_cursor array allocation.
>>>> - Fix free of unintialized pointer in xfs_acl_valid error path.
>>>> - Guard against path string overflows.
>>>> - Check strdup results properly in initallfs().
>>>> - Fix attribute no_change_count logic.
>>>> - Remove extraneous close() in fsrallfs().
>>>> - xfs_repair now skips the freelist scan of a corrupt agf
>>>> when in no-modify mode.
>>>> - xfs_db now skips freelist scans of corrupt agfs.
>>>> - Remove unconditional ASSERT(0) in xfs_repair.
>>>> - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf space.
>>>> - Add depraction message for xfs_check.
>>>> - xfs_quota allow user or group names beginning with digits reported by
>>>> James Carter.
>>>> - Fix manpages and usage() spelling, errors and omissions.
>>>>
>>>> I have placed a pre-release tarball here:
>>>>
>>>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>>>>
>>>>
>>>> Please take a look and report any issues before next Wednesday (08 May
>>>> 2013). If there are other patches which you feel are essential, now is
>>>> the time to say so.
>>>>
>>>> Regards
>>>> --Rich
>>>
>>> The new lines (below) in xfs_check.sh breaks older xfstests:
>>>
>>>    xfs_check is deprecated and scheduled for removal in June 2014.
>>>    Please use xfs_repair -n<dev>  instead.
>>
>> Hum, I thought xfstests stopped calling xfs_check.sh and implemented
>> its own xfs_check internally:
>>
>> commit 187bccd310dc253feaebd69df4ccdda21eee12d0
>> Author: Chandra Seetharaman<sekharan@us.ibm.com>
>> Date:   Thu Apr 18 17:44:02 2013 +0000
>>
>>      xfstests: Remove dependence of xfs_check script
>>
>>      Replace the usage of the script xfs_check and add the relevant code to
>>      xfstests.
>>
>> ...
>> -        [ "$XFS_CHECK_PROG" = "" ]&&  _fatal "xfs_check not found"
>> ... etc ...
>>
>> where is check getting called directly?
>>
>> (Or: is your xfstests up to date?)
>>
>> -Eric
> 
> I disclosed it as an older xfstests.

Sorry, I missed that.

> It is conceivable that people will install the latest xfsprogs and not upgrade xfstests. I can hear it now, "It used to just work..." :)

So what's the proposed solution? ;)

TBH I think xfstests is the kind of thing that is in so much flux you should always assume you need a newer version.

And since it's mostly qe/devel types using it, I'd submit that they can figure it out, but if you have a better idea, I'm all ears!

Is it the return code of xfs_check or the extra output that's breaking xfstests?

<looks>

It's the extra output I guess.  I don't know how to issue a deprecation message w/o adding output, so it seems like this is a hiccup we'll have to live with.

I suppose we could add "if you're using xfstests, upgrade it now!" to the message.  :)

-Eric

> --Mark.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Dave Chinner]

On Wed, May 01, 2013 at 04:23:28PM -0500, Eric Sandeen wrote:
> On 5/1/13 4:17 PM, Mark Tinguely wrote:
> > On 05/01/13 16:01, Eric Sandeen wrote:
> >> On 5/1/13 3:35 PM, Mark Tinguely wrote:
> >>> On 05/01/13 15:12, Rich Johnston wrote:
> >>>> I have placed a pre-release tarball here:
> >>>>
> >>>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
> >>>>
> >>>>
> >>>> Please take a look and report any issues before next Wednesday (08 May
> >>>> 2013). If there are other patches which you feel are essential, now is
> >>>> the time to say so.
> >>>>
> >>>> Regards
> >>>> --Rich
> >>>
> >>> The new lines (below) in xfs_check.sh breaks older xfstests:
> >>>
> >>>    xfs_check is deprecated and scheduled for removal in June 2014.
> >>>    Please use xfs_repair -n<dev>  instead.
> >>
> >> Hum, I thought xfstests stopped calling xfs_check.sh and implemented
> >> its own xfs_check internally:
> >>
> >> commit 187bccd310dc253feaebd69df4ccdda21eee12d0
> >> Author: Chandra Seetharaman<sekharan@us.ibm.com>
> >> Date:   Thu Apr 18 17:44:02 2013 +0000
> >>
> >>      xfstests: Remove dependence of xfs_check script
> >>
> >>      Replace the usage of the script xfs_check and add the relevant code to
> >>      xfstests.
> >>
> >> ...
> >> -        [ "$XFS_CHECK_PROG" = "" ]&&  _fatal "xfs_check not found"
> >> ... etc ...
> >>
> >> where is check getting called directly?
> >>
> >> (Or: is your xfstests up to date?)
> >>
> >> -Eric
> > 
> > I disclosed it as an older xfstests.
> 
> Sorry, I missed that.
> 
> > It is conceivable that people will install the latest xfsprogs and not upgrade xfstests. I can hear it now, "It used to just work..." :)
> 
> So what's the proposed solution? ;)

Upgrade xfstests.

> TBH I think xfstests is the kind of thing that is in so much flux
> you should always assume you need a newer version.

That has always been the case.

> And since it's mostly qe/devel types using it, I'd submit that
> they can figure it out, but if you have a better idea, I'm all
> ears!

Given the number of people that are likely to hit this, then I think
leaving it as it stands is just fine. The expectation is that you
should be using an xfstests that matches the age of your userspace
tools, otherwise you are not going be running all the tests necessary
to exercise the current userspace functionality you have installed...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Michael L. Semon]

On 05/01/2013 04:35 PM, Mark Tinguely wrote:
> On 05/01/13 15:12, Rich Johnston wrote:
>> Hi Folks,
>>
>> Here are the changes for this release:
>>
>> xfsprogs-3.1.11 (30 April 2013)
>>
>> - Support for relative paths in xfs_quota thanks to Satoru Takeuchi.
>> - mkfs.xfs will always go into multidisk mode when filesystem
>> geometry is specified on the command line.
>> - Document all commands in xfs_io.
>> - Remove setfl command from xfs_io.
>> - xfs_metadump will obfuscate symlinks by path component.
>> - mkfs.xfs no longer accepts geometry settings smaller than the
>> physical sector size.
>> - xfs_logprint now supports multiply-logged inode fields and
>> handles continued inode transactions correctly.
>> - kill XLOG_SET
>> - Update release scripts to use git archive to address a
>> missing source file reported by Arkadiusz Mi?kiewicz
>> - Fix a build error with -Werror=format-security, reported
>> by Arkadiusz Mi?kiewicz
>> - mkfs.xfs no longer attempts to discard when -N option is used.
>> - Update 'make deb' to use tarball
>> - Sync up with log reservation changes in the kernel.
>> - Fix possible unallocated memory access in fiemap.
>> - Guard against string overflow in path_to_fspath.
>> - Fix setup_cursor array allocation.
>> - Fix free of unintialized pointer in xfs_acl_valid error path.
>> - Guard against path string overflows.
>> - Check strdup results properly in initallfs().
>> - Fix attribute no_change_count logic.
>> - Remove extraneous close() in fsrallfs().
>> - xfs_repair now skips the freelist scan of a corrupt agf
>> when in no-modify mode.
>> - xfs_db now skips freelist scans of corrupt agfs.
>> - Remove unconditional ASSERT(0) in xfs_repair.
>> - Reduce bb_numrecs in bno/cnt btrees when log consumes all agf space.
>> - Add depraction message for xfs_check.
>> - xfs_quota allow user or group names beginning with digits reported by
>> James Carter.
>> - Fix manpages and usage() spelling, errors and omissions.
>>
>> I have placed a pre-release tarball here:
>>
>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>>
>>
>>
>> Please take a look and report any issues before next Wednesday (08 May
>> 2013). If there are other patches which you feel are essential, now is
>> the time to say so.
>>
>> Regards
>> --Rich
>
> The new lines (below) in xfs_check.sh breaks older xfstests:
>
>    xfs_check is deprecated and scheduled for removal in June 2014.
>    Please use xfs_repair -n <dev> instead.
>
> xfstests' ./check thinks the TEST directory is inconsistent and stops.
> I simply commented the lines out of the installed /usr/sbin/xfs_check
> for my tests.
>
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 host 3.9.0-rc1+
> MKFS_OPTIONS  -- -f -bsize=4096 {SCRATCH_DEV}
> MOUNT_OPTIONS -- {SCRATCH_DEV} {SCRATCH_MNT}
>
> _check_xfs_filesystem: filesystem on {TEST_DEV} is inconsistent (c) (see
> check.full)
> Passed all 0 tests
>
> --Mark.

I'm battling this as well, coming to hazy conclusions late at night.  In 
the _xfs_check() function in common/rc of xfstests, there was something 
like this:

${XFS_DB_PROG}${DBOPTS} -F -i -p xfs_check -c "check$OPTS" $1

When doing XFS tests with an external logdev (at least), things failed 
that way, so I threw an "echo command_about_to_run" line just above 
that.  I got the impression that the flags "-l $TEST_LOGDEV" were being 
passed to xfs_db twice (not fatal), but I didn't see where the $TEST_DEV 
was being passed to xfs_db.  It looks like xfs_db is giving back the 
standard usage line.  Again, it was late last night, so might someone 
verify that the xfs_db is always called with the correct data dev or 
mountpoint?

Anyway, something indeed is up between the latest git xfsprogs and the 
latest xfstests, but my blame list hasn't been set yet.  I did see the 
deprecation message either in the ".full" file or one of the /tmp files 
left behind, so you are indeed correct about that.  Whether that's the 
only error is another matter.

BTW, it looked like xfs_check is scheduled for removal in June 2014, yet 
the xfstests folks are planning like it will be gone in June 2013.  Is 
the year in the deprecation message correct?

Thanks!

Michael

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfsprogs-3.1.11 pre-release please test!

[Eric Sandeen]

On 5/2/13 8:34 AM, Michael L. Semon wrote:
> On 05/01/2013 04:35 PM, Mark Tinguely wrote:
>> On 05/01/13 15:12, Rich Johnston wrote:
>>> Hi Folks,
>>> 
>>> Here are the changes for this release:
>>> 
>>> xfsprogs-3.1.11 (30 April 2013)
>>> 
>>> - Support for relative paths in xfs_quota thanks to Satoru
>>> Takeuchi. - mkfs.xfs will always go into multidisk mode when
>>> filesystem geometry is specified on the command line. - Document
>>> all commands in xfs_io. - Remove setfl command from xfs_io. -
>>> xfs_metadump will obfuscate symlinks by path component. -
>>> mkfs.xfs no longer accepts geometry settings smaller than the 
>>> physical sector size. - xfs_logprint now supports multiply-logged
>>> inode fields and handles continued inode transactions correctly. 
>>> - kill XLOG_SET - Update release scripts to use git archive to
>>> address a missing source file reported by Arkadiusz Mi?kiewicz -
>>> Fix a build error with -Werror=format-security, reported by
>>> Arkadiusz Mi?kiewicz - mkfs.xfs no longer attempts to discard
>>> when -N option is used. - Update 'make deb' to use tarball - Sync
>>> up with log reservation changes in the kernel. - Fix possible
>>> unallocated memory access in fiemap. - Guard against string
>>> overflow in path_to_fspath. - Fix setup_cursor array allocation. 
>>> - Fix free of unintialized pointer in xfs_acl_valid error path. -
>>> Guard against path string overflows. - Check strdup results
>>> properly in initallfs(). - Fix attribute no_change_count logic. -
>>> Remove extraneous close() in fsrallfs(). - xfs_repair now skips
>>> the freelist scan of a corrupt agf when in no-modify mode. -
>>> xfs_db now skips freelist scans of corrupt agfs. - Remove
>>> unconditional ASSERT(0) in xfs_repair. - Reduce bb_numrecs in
>>> bno/cnt btrees when log consumes all agf space. - Add depraction
>>> message for xfs_check. - xfs_quota allow user or group names
>>> beginning with digits reported by James Carter. - Fix manpages
>>> and usage() spelling, errors and omissions.
>>> 
>>> I have placed a pre-release tarball here:
>>> 
>>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
>>>
>>>
>>>
>>>
>>> 
Please take a look and report any issues before next Wednesday (08 May
>>> 2013). If there are other patches which you feel are essential,
>>> now is the time to say so.
>>> 
>>> Regards --Rich
>> 
>> The new lines (below) in xfs_check.sh breaks older xfstests:
>> 
>> xfs_check is deprecated and scheduled for removal in June 2014. 
>> Please use xfs_repair -n <dev> instead.
>> 
>> xfstests' ./check thinks the TEST directory is inconsistent and
>> stops. I simply commented the lines out of the installed
>> /usr/sbin/xfs_check for my tests.
>> 
>> FSTYP         -- xfs (debug) PLATFORM      -- Linux/x86_64 host
>> 3.9.0-rc1+ MKFS_OPTIONS  -- -f -bsize=4096 {SCRATCH_DEV} 
>> MOUNT_OPTIONS -- {SCRATCH_DEV} {SCRATCH_MNT}
>> 
>> _check_xfs_filesystem: filesystem on {TEST_DEV} is inconsistent (c)
>> (see check.full) Passed all 0 tests
>> 
>> --Mark.
> 
> I'm battling this as well, coming to hazy conclusions late at night.
> In the _xfs_check() function in common/rc of xfstests, there was
> something like this:
> 
> ${XFS_DB_PROG}${DBOPTS} -F -i -p xfs_check -c "check$OPTS" $1
> 
> When doing XFS tests with an external logdev (at least), things
> failed that way, so I threw an "echo command_about_to_run" line just
> above that.  I got the impression that the flags "-l $TEST_LOGDEV"
> were being passed to xfs_db twice (not fatal), but I didn't see where
> the $TEST_DEV was being passed to xfs_db.  It looks like xfs_db is
> giving back the standard usage line.  Again, it was late last night,
> so might someone verify that the xfs_db is always called with the
> correct data dev or mountpoint?

I'll send a patch.

> Anyway, something indeed is up between the latest git xfsprogs and
> the latest xfstests, but my blame list hasn't been set yet.  I did
> see the deprecation message either in the ".full" file or one of the
> /tmp files left behind, so you are indeed correct about that.
> Whether that's the only error is another matter.
> 
> BTW, it looked like xfs_check is scheduled for removal in June 2014,
> yet the xfstests folks are planning like it will be gone in June
> 2013.  Is the year in the deprecation message correct?

xfstests is planning ahead.  ;)  Nothing stops the end-user from dropping
a tool before the ultimate deprecation date...

-Eric

 
> Thanks!
> 
> Michael
> 
> _______________________________________________ xfs mailing list 
> xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs