From: Mark Tinguely <tinguely@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount
Date: Thu, 02 May 2013 10:09:06 -0500 [thread overview]
Message-ID: <51828192.6040101@sgi.com> (raw)
In-Reply-To: <51824CA8.9000209@oracle.com>
On 05/02/13 06:23, Jeff Liu wrote:
> v2->v1:
> Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.
>
>
> From: Jie Liu<jeff.liu@oracle.com>
>
> Remove struct xfs_chash from struct xfs_mount as there is no user of
> it nowadays.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> Reviewed-by: Dave Chinner<dchinner@redhat.com>
> ---
> fs/xfs/xfs_mount.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index bc90706..b68e56b 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -192,8 +192,6 @@ typedef struct xfs_mount {
> xfs_dablk_t m_dirleafblk; /* blockno of dir non-data v2 */
> xfs_dablk_t m_dirfreeblk; /* blockno of dirfreeindex v2 */
> uint m_chsize; /* size of next field */
> - struct xfs_chash *m_chash; /* fs private inode per-cluster
> - * hash table */
> atomic_t m_active_trans; /* number trans frozen */
> #ifdef HAVE_PERCPU_SB
> xfs_icsb_cnts_t __percpu *m_sb_cnts; /* per-cpu superblock counters */
Your mailer may have damaged the patch. The <TAB> are now spaces.
FYI, I had problems with another patch of yours:
http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
starting at the line:
@@ -630,6 +688,12 @@ xfs_log_mount(
I think that this patch can be fixed rather resent. Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-02 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 11:23 [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount Jeff Liu
2013-05-02 15:09 ` Mark Tinguely [this message]
2013-05-02 15:35 ` Jeff Liu
2013-06-17 22:55 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51828192.6040101@sgi.com \
--to=tinguely@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox