[PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

[PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

[Jeff Liu]

v2->v1:
Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.


From: Jie Liu <jeff.liu@oracle.com>

Remove struct xfs_chash from struct xfs_mount as there is no user of
it nowadays.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
---
 fs/xfs/xfs_mount.h |    2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index bc90706..b68e56b 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -192,8 +192,6 @@ typedef struct xfs_mount {
        xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
        xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
        uint                    m_chsize;       /* size of next field */
-       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
-                                                * hash table */
        atomic_t                m_active_trans; /* number trans frozen */
 #ifdef HAVE_PERCPU_SB
        xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */
-- 
1.7.9.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

[Mark Tinguely]

On 05/02/13 06:23, Jeff Liu wrote:
> v2->v1:
> Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.
>
>
> From: Jie Liu<jeff.liu@oracle.com>
>
> Remove struct xfs_chash from struct xfs_mount as there is no user of
> it nowadays.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> Reviewed-by: Dave Chinner<dchinner@redhat.com>
> ---
>   fs/xfs/xfs_mount.h |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index bc90706..b68e56b 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -192,8 +192,6 @@ typedef struct xfs_mount {
>          xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
>          xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
>          uint                    m_chsize;       /* size of next field */
> -       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
> -                                                * hash table */
>          atomic_t                m_active_trans; /* number trans frozen */
>   #ifdef HAVE_PERCPU_SB
>          xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */

Your mailer may have damaged the patch. The <TAB> are now spaces.

FYI, I had problems with another patch of yours:
	http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
starting at the line:
	@@ -630,6 +688,12 @@ xfs_log_mount(

I think that this patch can be fixed rather resent. Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

[Jeff Liu]

On 05/02/2013 11:09 PM, Mark Tinguely wrote:
> On 05/02/13 06:23, Jeff Liu wrote:
>> v2->v1:
>> Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.
>>
>>
>> From: Jie Liu<jeff.liu@oracle.com>
>>
>> Remove struct xfs_chash from struct xfs_mount as there is no user of
>> it nowadays.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>> Reviewed-by: Dave Chinner<dchinner@redhat.com>
>> ---
>>   fs/xfs/xfs_mount.h |    2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
>> index bc90706..b68e56b 100644
>> --- a/fs/xfs/xfs_mount.h
>> +++ b/fs/xfs/xfs_mount.h
>> @@ -192,8 +192,6 @@ typedef struct xfs_mount {
>>          xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
>>          xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
>>          uint                    m_chsize;       /* size of next field */
>> -       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
>> -                                                * hash table */
>>          atomic_t                m_active_trans; /* number trans frozen */
>>   #ifdef HAVE_PERCPU_SB
>>          xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */
> 
> Your mailer may have damaged the patch. The <TAB> are now spaces.
> 
> FYI, I had problems with another patch of yours:
> 	http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
> starting at the line:
> 	@@ -630,6 +688,12 @@ xfs_log_mount(
> 
> I think that this patch can be fixed rather resent. Looks good.
Not sure why my email client did a bad formating, will take care of it anyway.

Thanks,
-Jeff
> 
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

[Ben Myers]

On Thu, May 02, 2013 at 07:23:20PM +0800, Jeff Liu wrote:
> v2->v1:
> Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.
> 
> 
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Remove struct xfs_chash from struct xfs_mount as there is no user of
> it nowadays.
> 
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs