From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 326577F58 for ; Thu, 2 May 2013 10:35:44 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id ED089304062 for ; Thu, 2 May 2013 08:35:43 -0700 (PDT) Message-ID: <518287C7.30802@oracle.com> Date: Thu, 02 May 2013 23:35:35 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount References: <51824CA8.9000209@oracle.com> <51828192.6040101@sgi.com> In-Reply-To: <51828192.6040101@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Mark Tinguely Cc: "xfs@oss.sgi.com" On 05/02/2013 11:09 PM, Mark Tinguely wrote: > On 05/02/13 06:23, Jeff Liu wrote: >> v2->v1: >> Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/. >> >> >> From: Jie Liu >> >> Remove struct xfs_chash from struct xfs_mount as there is no user of >> it nowadays. >> >> Signed-off-by: Jie Liu >> Reviewed-by: Dave Chinner >> --- >> fs/xfs/xfs_mount.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h >> index bc90706..b68e56b 100644 >> --- a/fs/xfs/xfs_mount.h >> +++ b/fs/xfs/xfs_mount.h >> @@ -192,8 +192,6 @@ typedef struct xfs_mount { >> xfs_dablk_t m_dirleafblk; /* blockno of dir non-data v2 */ >> xfs_dablk_t m_dirfreeblk; /* blockno of dirfreeindex v2 */ >> uint m_chsize; /* size of next field */ >> - struct xfs_chash *m_chash; /* fs private inode per-cluster >> - * hash table */ >> atomic_t m_active_trans; /* number trans frozen */ >> #ifdef HAVE_PERCPU_SB >> xfs_icsb_cnts_t __percpu *m_sb_cnts; /* per-cpu superblock counters */ > > Your mailer may have damaged the patch. The are now spaces. > > FYI, I had problems with another patch of yours: > http://oss.sgi.com/archives/xfs/2013-05/msg00022.html > starting at the line: > @@ -630,6 +688,12 @@ xfs_log_mount( > > I think that this patch can be fixed rather resent. Looks good. Not sure why my email client did a bad formating, will take care of it anyway. Thanks, -Jeff > > Reviewed-by: Mark Tinguely > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs