From: Eric Sandeen <sandeen@sandeen.net>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: xfs@oss.sgi.com
Subject: Re: Internal error xfs_sb_read_verify at line 726
Date: Mon, 06 May 2013 12:04:16 -0500 [thread overview]
Message-ID: <5187E290.8090109@sandeen.net> (raw)
In-Reply-To: <20130506112717.GA502@x4>
On 5/6/13 6:27 AM, Markus Trippelsdorf wrote:
> Today I accidentally tried to mount my backup disk at /dev/sdc instead
> of /dev/sdc1 and this is what happened:
>
> ...
> EXT4-fs (sdc): VFS: Can't find ext4 filesystem
> FAT-fs (sdc): bogus number of reserved sectors
> FAT-fs (sdc): Can't find a valid FAT filesystem
> FAT-fs (sdc): bogus number of reserved sectors
> FAT-fs (sdc): Can't find a valid FAT filesystem
> ISOFS: Unable to identify CD-ROM format.
> XFS (sdc): bad magic number
> ffff8800db620000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> ffff8800db620010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> ffff8800db620020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> ffff8800db620030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> XFS (sdc): Internal error xfs_sb_read_verify at line 726 of file fs/xfs/xfs_mount.c. Caller 0xffffffff8119e5cd
This seems to be a recent regression.
Comments above xfs_sb_quiet_read_verify() indicate that this behavior is
to be avoided:
* We may be probed for a filesystem match, so we may not want to emit
* messages when the superblock buffer is not actually an XFS superblock.
and it checks for proper magic prior to all the chattiness above int
that function.
The superblock read is suposed to choose whether to be noisy or not,
in xfs_readsb():
reread:
bp = xfs_buf_read_uncached(mp->m_ddev_targp, XFS_SB_DADDR,
BTOBB(sector_size), 0,
loud ? &xfs_sb_buf_ops
: &xfs_sb_quiet_buf_ops);
so it looks like this *should* be working properly.
I'll look into it and send a patch in a a bit.
(FWIW though, I don't get this probing from the kernel; I only
see it if I specify a -t xfs type on the mount command)
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-06 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 11:27 Internal error xfs_sb_read_verify at line 726 Markus Trippelsdorf
2013-05-06 17:04 ` Eric Sandeen [this message]
2013-05-06 18:30 ` Markus Trippelsdorf
2013-05-06 19:14 ` Eric Sandeen
2013-05-06 19:26 ` Markus Trippelsdorf
2013-05-06 19:41 ` Eric Sandeen
2013-05-06 19:55 ` Markus Trippelsdorf
2013-05-06 20:49 ` Eric Sandeen
2013-05-06 21:48 ` Eric Sandeen
2013-05-07 0:23 ` Dave Chinner
2013-05-07 0:34 ` Dave Chinner
2013-05-07 0:38 ` Eric Sandeen
2013-05-07 0:54 ` Dave Chinner
2013-05-07 5:24 ` Mount probing not silent. " Markus Trippelsdorf
2013-05-07 13:43 ` Markus Trippelsdorf
2013-05-09 7:29 ` Karel Zak
2013-05-06 21:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187E290.8090109@sandeen.net \
--to=sandeen@sandeen.net \
--cc=markus@trippelsdorf.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox