From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Dave Jones <davej@redhat.com>, CAI Qian <caiqian@redhat.com>,
xfs@oss.sgi.com
Subject: Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)
Date: Tue, 07 May 2013 17:45:20 -0500 [thread overview]
Message-ID: <51898400.8000900@sgi.com> (raw)
In-Reply-To: <20130507222256.GD24635@dastard>
On 05/07/13 17:22, Dave Chinner wrote:
> On Tue, May 07, 2013 at 03:24:28PM -0500, Mark Tinguely wrote:
>> On 05/07/13 15:22, Dave Jones wrote:
>>> On Tue, May 07, 2013 at 03:04:33PM -0500, Mark Tinguely wrote:
>>> > On 05/07/13 14:59, Dave Jones wrote:
>>> > > On Tue, May 07, 2013 at 02:58:15PM -0500, Mark Tinguely wrote:
>>> > >
>>> > > > > I can hit this almost instantly with fsx. I'll do a bisect, though
>>> > > > > it sounds like you already have a suspect.
>>> > > > >
>>> > > >
>>> > > > If you want to try kmem debug of Linux 3.8 that would help.
>>> > >
>>> > > I'm not sure what that is.
>>> >
>>> > Sorry, if you would test Linux 3.8 with "CONFIG_DEBUG_SLAB=y".
>>>
>>> Ah, done that. (I pretty much always run with it).
>>>
>>> This is something new. Even 3.9 was fine. It's only since
>>> the recent xfs merge.
>>>
>>> Dave
>>>
>>
>> git revert 666d644cd72a9ec58b353209ff191d7430f3b357
>
> That won't prevent the use after free. That commit fixed a problem
> that could lead to a use after free, but what we are seeing here is
> that it has ultimately exposed a previously unknown issue that
> causes the use after free.
>
> Basically what is happening is that there are two commits for the
> EFD being processed, when there should only be one. I'm not sure how
> this is happening yet, but these three traces came out from my debug
> sequentially when running generic/006:
>
Sorry for the misleading statement. Yes, I agree that patch is a good
thing. I meant that Dave and only Dave revert it and only to test if
that patch was the change that caused the new symptom - which we know
now that it is.
I added some asserts and did not learn anything new except where the efi
item was already freed.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-07 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:37 xfs_efi_item slab corruption. (v3.9-10936-g51a26ae) Dave Jones
2013-05-07 19:04 ` Mark Tinguely
2013-05-07 19:07 ` Dave Jones
2013-05-07 19:24 ` Mark Tinguely
2013-05-07 19:31 ` Dave Jones
2013-05-07 19:58 ` Mark Tinguely
2013-05-07 19:59 ` Dave Jones
2013-05-07 20:04 ` Mark Tinguely
2013-05-07 20:22 ` Dave Jones
2013-05-07 20:24 ` Mark Tinguely
2013-05-07 22:22 ` Dave Chinner
2013-05-07 22:45 ` Mark Tinguely [this message]
2013-05-07 23:54 ` Dave Chinner
2013-05-08 0:43 ` Dave Jones
2013-05-08 13:24 ` Mark Tinguely
2013-05-10 1:38 ` Dave Chinner
2013-05-11 12:09 ` Dmitry Monakhov
2013-05-12 0:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51898400.8000900@sgi.com \
--to=tinguely@sgi.com \
--cc=caiqian@redhat.com \
--cc=davej@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox